You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2013/03/13 15:18:29 UTC
Review Request: Rave 891 - Refactor rave js
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9901/
-----------------------------------------------------------
Review request for rave.
Description
-------
The same update that was submitted through github, now in svn form.
https://github.com/apache/rave/pull/3
This addresses bug Rave-891.
https://issues.apache.org/jira/browse/Rave-891
Diffs
-----
trunk/rave-components/pom.xml 1455600
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java 1455600
trunk/rave-portal-resources/pom.xml 1455600
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1455600
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/client_side_templates.tag 1455600
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1455600
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1455600
trunk/rave-portal-resources/src/main/webapp/static/script/rave_backbone.js PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1455600
trunk/rave-portal-resources/src/main/webapp/static/script/rave_models.js PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1455600
trunk/rave-portal-resources/src/main/webapp/static/script/rave_ui.js 1455600
trunk/rave-providers/rave-opensocial-provider/rave-opensocial-server/rave-shindig-resources/src/main/webapp/index.jsp 1455600
Diff: https://reviews.apache.org/r/9901/diff/
Testing
-------
Thanks,
Erin Noe-Payne
Re: Review Request: Rave 891 - Refactor rave js
Posted by Matt Franklin <mf...@apache.org>.
> On March 13, 2013, 2:28 p.m., Matt Franklin wrote:
> > Ship It!
I will commit this. This was reviewed on Github initially.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9901/#review17803
-----------------------------------------------------------
On March 13, 2013, 2:18 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9901/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 2:18 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> The same update that was submitted through github, now in svn form.
> https://github.com/apache/rave/pull/3
>
>
> This addresses bug Rave-891.
> https://issues.apache.org/jira/browse/Rave-891
>
>
> Diffs
> -----
>
> trunk/rave-components/pom.xml 1455600
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java 1455600
> trunk/rave-portal-resources/pom.xml 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/client_side_templates.tag 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1455600
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_backbone.js PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1455600
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_models.js PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1455600
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_ui.js 1455600
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-server/rave-shindig-resources/src/main/webapp/index.jsp 1455600
>
> Diff: https://reviews.apache.org/r/9901/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erin Noe-Payne
>
>
Re: Review Request: Rave 891 - Refactor rave js
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9901/#review17803
-----------------------------------------------------------
Ship it!
Ship It!
- Matt Franklin
On March 13, 2013, 2:18 p.m., Erin Noe-Payne wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9901/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 2:18 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> The same update that was submitted through github, now in svn form.
> https://github.com/apache/rave/pull/3
>
>
> This addresses bug Rave-891.
> https://issues.apache.org/jira/browse/Rave-891
>
>
> Diffs
> -----
>
> trunk/rave-components/pom.xml 1455600
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java 1455600
> trunk/rave-portal-resources/pom.xml 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/client_side_templates.tag 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/rave_js.tag 1455600
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tags/third_party_js.tag 1455600
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_backbone.js PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1455600
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_models.js PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_person_profile.js 1455600
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_ui.js 1455600
> trunk/rave-providers/rave-opensocial-provider/rave-opensocial-server/rave-shindig-resources/src/main/webapp/index.jsp 1455600
>
> Diff: https://reviews.apache.org/r/9901/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erin Noe-Payne
>
>