You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Adriaan Schmidt (JIRA)" <ji...@apache.org> on 2017/03/31 06:36:41 UTC

[jira] [Updated] (THRIFT-4140) Use of non-thread-safe function gmtime()

     [ https://issues.apache.org/jira/browse/THRIFT-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adriaan Schmidt updated THRIFT-4140:
------------------------------------
    Attachment: THRIFT-4140.patch

> Use of non-thread-safe function gmtime()
> ----------------------------------------
>
>                 Key: THRIFT-4140
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4140
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.10.0
>            Reporter: Adriaan Schmidt
>            Priority: Minor
>         Attachments: THRIFT-4140.patch
>
>
> Method *THttpServer::getTimeRFC1123()* (in lib/cpp/src/thr8ft/transport/THttpServer.cpp) uses gmtime().
> This function is documented to be not thread-safe (https://www.gnu.org/software/libc/manual/html_node/Broken_002ddown-Time.html).
> Instead, we should use gmtime_r().



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)