You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Forrest Xia (JIRA)" <ji...@apache.org> on 2010/06/25 07:24:49 UTC

[jira] Created: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Uninstallation does not remove the installed unique dependencies.
-----------------------------------------------------------------

                 Key: GERONIMO-5404
                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
    Affects Versions: 3.0-M1, 3.0
            Reporter: Forrest Xia


Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy install-plugin will install two artifacts into the geronimo repository, one is the plugin itself, another is the original sample. 

When we uninstall the plugin from the admin console, the installed original sample is still in the repository, not removed. I think it should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Posted by Shawn Jiang <ge...@gmail.com>.
Ops,  committed trunk@r1021638 to fix this.

On Tue, Oct 12, 2010 at 11:33 AM, Forrest Xia (JIRA) <ji...@apache.org>wrote:

>
>    [
> https://issues.apache.org/jira/browse/GERONIMO-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920076#action_12920076]
>
> Forrest Xia commented on GERONIMO-5404:
> ---------------------------------------
>
> rev1021296 change to PluginMetadataGeneratorMojo.java cause daytrader web
> jdbc tomcat plugin failed to be built, the exception is like this:
>
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Could not create plugin metadata
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Could not create
> plugin metadata
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
>        at
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
>        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
>        at org.apache.maven.DefaultMaven.exec
>
> > Uninstallation does not remove the installed unique dependencies.
> > -----------------------------------------------------------------
> >
> >                 Key: GERONIMO-5404
> >                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
> >             Project: Geronimo
> >          Issue Type: Bug
> >      Security Level: public(Regular issues)
> >    Affects Versions: 3.0-M1, 3.0
> >            Reporter: Forrest Xia
> >
> > Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy
> install-plugin will install two artifacts into the geronimo repository, one
> is the plugin itself, another is the original sample.
> > When we uninstall the plugin from the admin console, the installed
> original sample is still in the repository, not removed. I think it should
> be removed.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 
Shawn

[jira] Commented: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Posted by "Forrest Xia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920076#action_12920076 ] 

Forrest Xia commented on GERONIMO-5404:
---------------------------------------

rev1021296 change to PluginMetadataGeneratorMojo.java cause daytrader web jdbc tomcat plugin failed to be built, the exception is like this:

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Could not create plugin metadata

[INFO] ------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: Could not create plugin metadata
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
	at org.apache.maven.DefaultMaven.exec

> Uninstallation does not remove the installed unique dependencies.
> -----------------------------------------------------------------
>
>                 Key: GERONIMO-5404
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0-M1, 3.0
>            Reporter: Forrest Xia
>
> Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy install-plugin will install two artifacts into the geronimo repository, one is the plugin itself, another is the original sample. 
> When we uninstall the plugin from the admin console, the installed original sample is still in the repository, not removed. I think it should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Posted by "Forrest Xia (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Forrest Xia closed GERONIMO-5404.
---------------------------------

    Resolution: Fixed
      Assignee: Shawn Jiang

Verified, and this problem is fixed by removing dependency entry in geronimo-plugin.xml.

> Uninstallation does not remove the installed unique dependencies.
> -----------------------------------------------------------------
>
>                 Key: GERONIMO-5404
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0-M1, 3.0
>            Reporter: Forrest Xia
>            Assignee: Shawn Jiang
>
> Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy install-plugin will install two artifacts into the geronimo repository, one is the plugin itself, another is the original sample. 
> When we uninstall the plugin from the admin console, the installed original sample is still in the repository, not removed. I think it should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Posted by "Forrest Xia (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920077#action_12920077 ] 

Forrest Xia commented on GERONIMO-5404:
---------------------------------------

Oops, exception msg is tailored and incomplet, so repost it here:

Caused by: org.apache.maven.plugin.MojoExecutionException: Could not create plugin metadata
	at org.apache.geronimo.mavenplugins.car.PluginMetadataGeneratorMojo.execute(PluginMetadataGeneratorMojo.java:286)
	at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
	... 17 more
Caused by: java.lang.NullPointerException
	at org.apache.geronimo.mavenplugins.car.PluginMetadataGeneratorMojo.removeIncludedModule(PluginMetadataGeneratorMojo.java:311)
	at org.apache.geronimo.mavenplugins.car.PluginMetadataGeneratorMojo.execute(PluginMetadataGeneratorMojo.java:266)
	... 19 more


> Uninstallation does not remove the installed unique dependencies.
> -----------------------------------------------------------------
>
>                 Key: GERONIMO-5404
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0-M1, 3.0
>            Reporter: Forrest Xia
>
> Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy install-plugin will install two artifacts into the geronimo repository, one is the plugin itself, another is the original sample. 
> When we uninstall the plugin from the admin console, the installed original sample is still in the repository, not removed. I think it should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882455#action_12882455 ] 

David Jencks commented on GERONIMO-5404:
----------------------------------------

Since the original javaee app is copied into the geronimo plugin, we should try to find a way to make it not a dependency of the plugin so it isn't installed at all.

I'm not sure the effort involved in trying to count uses of an artifact  to determine if it safe to remove is worth the result.

I also think we should move our dependency installation/tracking code to use felix features as what we are doing pretty much duplicates that.

> Uninstallation does not remove the installed unique dependencies.
> -----------------------------------------------------------------
>
>                 Key: GERONIMO-5404
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0-M1, 3.0
>            Reporter: Forrest Xia
>
> Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy install-plugin will install two artifacts into the geronimo repository, one is the plugin itself, another is the original sample. 
> When we uninstall the plugin from the admin console, the installed original sample is still in the repository, not removed. I think it should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-5404) Uninstallation does not remove the installed unique dependencies.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919782#action_12919782 ] 

Shawn Jiang commented on GERONIMO-5404:
---------------------------------------

If you mark the included module in pom as "provided".  It wont' be included in the dependencies list of the geronimo-plugin.xml .

Anyway,  commited a fix for tunck@r1021296 to remove the included module before writing to  geronimo-plugin.xml.

> Uninstallation does not remove the installed unique dependencies.
> -----------------------------------------------------------------
>
>                 Key: GERONIMO-5404
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5404
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0-M1, 3.0
>            Reporter: Forrest Xia
>
> Use car-maven-plugin to make a G sample as a geronimo plugin, the deploy install-plugin will install two artifacts into the geronimo repository, one is the plugin itself, another is the original sample. 
> When we uninstall the plugin from the admin console, the installed original sample is still in the repository, not removed. I think it should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.