You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:57:52 UTC
[GitHub] [hadoop] xinglin opened a new pull request, #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations
xinglin opened a new pull request, #4962:
URL: https://github.com/apache/hadoop/pull/4962
(cherry picked from commit e18d8062126951b01d04d14374cc04053167735b)
### Description of PR
backport of HDFS-16024 from trunk to branch-3.3.
minor conflict resolved. The conflict is due to some code refactoring done in HDFS-15766. Not include HDFS-15766 as part of this PR (That should be done as another backport PR).
### How was this patch tested?
mvn test -Dtest="TestRouterRpc"
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.federation.router.TestRouterRpc
[INFO] Tests run: 47, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 33.225 s - in org.apache.hadoop.hdfs.server.federation.router.TestRouterRpc
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 47, Failures: 0, Errors: 0, Skipped: 0
```
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka merged pull request #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations
Posted by GitBox <gi...@apache.org>.
aajisaka merged PR #4962:
URL: https://github.com/apache/hadoop/pull/4962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on PR #4962:
URL: https://github.com/apache/hadoop/pull/4962#issuecomment-1264912310
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 7m 8s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 38s | | branch-3.3 passed |
| +1 :green_heart: | compile | 0m 51s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 0m 42s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 0m 54s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 1m 12s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 1m 39s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 24m 57s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 39s | | the patch passed |
| +1 :green_heart: | compile | 0m 34s | | the patch passed |
| +1 :green_heart: | javac | 0m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 26s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 41s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 57s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 20s | | the patch passed |
| +1 :green_heart: | shadedclient | 24m 14s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 15m 44s | | hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 46s | | The patch does not generate ASF License warnings. |
| | | 120m 55s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4962/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4962 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 29ab37fcaf3b 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / 278374852bba7adfeb51f7fa3d2fcce709df337b |
| Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4962/1/testReport/ |
| Max. process+thread count | 2592 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4962/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations
Posted by GitBox <gi...@apache.org>.
aajisaka commented on PR #4962:
URL: https://github.com/apache/hadoop/pull/4962#issuecomment-1270205799
> @aajisaka @jojochuang - Do we need a new jira for cherry pick to specific branches ?
I think no. In the past we had to reopen the jira or create a separate jira to run precommit jenkins tests for specific branches, but now we can open a separate PR to test against different branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on pull request #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations
Posted by GitBox <gi...@apache.org>.
aajisaka commented on PR #4962:
URL: https://github.com/apache/hadoop/pull/4962#issuecomment-1272567467
Merged. Thank you @xinglin and @dineshchitlangia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on pull request #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations
Posted by GitBox <gi...@apache.org>.
xinglin commented on PR #4962:
URL: https://github.com/apache/hadoop/pull/4962#issuecomment-1272105715
Hi @dineshchitlangia,
Can we merge/commit this PR now?
Here is another small PR related with this change, https://github.com/apache/hadoop/pull/4974. Appreciated if you can take a look as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org