You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/08 12:05:02 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5421: server: fix addCluster for vmware, others
shwstppr opened a new pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421
### Description
With 87ddc76, value column in cloud.cluster_details has been made non-nullable.
While adding a cluster (especially VMware), addCluster API can be called without username password. Username and password are updated in cluster details entry later after successful discovery.
This PR stores an empty string instead of a null value when the initial cluster entry is made in the DB.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-915769274
@rhtyd only main, as 87ddc76 from PR #5274 was merged in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-915175799
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-918267320
@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-918762271
<b>Trillian test result (tid-2020)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43210 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5421-t2020-xenserver-71.zip
Smoke tests completed. 87 look OK, 2 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 97.71 | test_kubernetes_clusters.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1787.82 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1787.87 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-916305527
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-915206036
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-916308293
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-916633719
<b>Trillian test result (tid-2005)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38353 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5421-t2005-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-916641320
<b>Trillian test result (tid-2000)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40256 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5421-t2000-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-915181194
Does it affect 4.15 too @shwstppr or just main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-918266860
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-918741698
<b>Trillian test result (tid-2021)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40053 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5421-t2021-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-915175196
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421#issuecomment-918765450
<b>Trillian test result (tid-2022)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5421-t2022-vmware-65u2.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn | `Failure` | 329.24 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5421: server: fix addCluster for vmware, others
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5421:
URL: https://github.com/apache/cloudstack/pull/5421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org