You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/10/21 09:41:36 UTC

[PR] ci: Fix CI for bindings python [iceberg-rust]

Xuanwo opened a new pull request, #678:
URL: https://github.com/apache/iceberg-rust/pull/678

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: Fix CI for bindings python [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #678:
URL: https://github.com/apache/iceberg-rust/pull/678


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: Fix CI for bindings python [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #678:
URL: https://github.com/apache/iceberg-rust/pull/678#issuecomment-2433240259

   > FYI, CI failing on main
   > 
   > https://github.com/apache/iceberg-rust/commits/main/
   > 
   > 
   > 
   > Is it related to this PR? 
   > 
   > 
   > 
   > error message,
   > 
   > ```
   > 
   > error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   > 
   >    --> crates/iceberg/src/io/file_io.rs:100:15
   > 
   >     |
   > 
   > 100 |         Ok(op.is_exist(relative_path).await?)
   > 
   >     |               ^^^^^^^^
   > 
   >     |
   > 
   >     = note: `-D deprecated` implied by `-D warnings`
   > 
   >     = help: to override `-D warnings` add `#[allow(deprecated)]`
   > 
   > 
   > 
   > error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   > 
   >    --> crates/iceberg/src/io/file_io.rs:246:14
   > 
   >     |
   > 
   > 246 |             .is_exist(&self.path[self.relative_path_pos..])
   > 
   >     |              ^^^^^^^^
   > 
   > 
   > 
   > error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
   > 
   >    --> crates/iceberg/src/io/file_io.rs:328:14
   > 
   >     |
   > 
   > 328 |             .is_exist(&self.path[self.relative_path_pos..])
   > 
   >     |              ^^^^^^^^
   > 
   > ```
   
   Not related. opendal released a new version. I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: Fix CI for bindings python [iceberg-rust]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #678:
URL: https://github.com/apache/iceberg-rust/pull/678#issuecomment-2433021197

   FYI, CI failing on main
   https://github.com/apache/iceberg-rust/commits/main/
   
   Is it related to this PR? 
   
   error message,
   ```
   error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
      --> crates/iceberg/src/io/file_io.rs:100:15
       |
   100 |         Ok(op.is_exist(relative_path).await?)
       |               ^^^^^^^^
       |
       = note: `-D deprecated` implied by `-D warnings`
       = help: to override `-D warnings` add `#[allow(deprecated)]`
   
   error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
      --> crates/iceberg/src/io/file_io.rs:246:14
       |
   246 |             .is_exist(&self.path[self.relative_path_pos..])
       |              ^^^^^^^^
   
   error: use of deprecated method `opendal::Operator::is_exist`: rename to `exists` for consistence with `std::fs::exists`
      --> crates/iceberg/src/io/file_io.rs:328:14
       |
   328 |             .is_exist(&self.path[self.relative_path_pos..])
       |              ^^^^^^^^
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] ci: Fix CI for bindings python [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #678:
URL: https://github.com/apache/iceberg-rust/pull/678#issuecomment-2428249949

   Hi, @kevinjqliu @sungwy, thank you for the review!
   
   Github fix this from the runner side: https://github.com/actions/runner-images/pull/10794
   
   I believe we can continue to use pip in the current manner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org