You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 09:00:05 UTC

[GitHub] [airflow] FloChehab opened a new pull request #11675: fix pod launcher rolebinding in helm chart

FloChehab opened a new pull request #11675:
URL: https://github.com/apache/airflow/pull/11675


   Hello,
   
   This PR is a tiny followup to #11034: if `multiNamespaceMode = False` then we should reference a `Role` and not a `ClusterRole` in the roleRef of `pod-launcher-rolebinding.yaml`.
   
   Also,
   with #11034 & this PR, we should be able to close #10190.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] FloChehab edited a comment on pull request #11675: fix pod launcher rolebinding in helm chart

Posted by GitBox <gi...@apache.org>.
FloChehab edited a comment on pull request #11675:
URL: https://github.com/apache/airflow/pull/11675#issuecomment-712741989


   Also, there is an issue in the `values.yaml` https://github.com/apache/airflow/blob/master/chart/values.yaml#L643
   
   `'False'` string is not falsy for helm, so this it's not working. Should be a plain `false`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] dimberman merged pull request #11675: fix pod launcher rolebinding in helm chart

Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #11675:
URL: https://github.com/apache/airflow/pull/11675


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11675: fix pod launcher rolebinding in helm chart

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11675:
URL: https://github.com/apache/airflow/pull/11675#issuecomment-713151793


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] FloChehab commented on pull request #11675: fix pod launcher rolebinding in helm chart

Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #11675:
URL: https://github.com/apache/airflow/pull/11675#issuecomment-712741989


   Also, there is an issue in the `values.yaml` https://github.com/apache/airflow/blob/master/chart/values.yaml#L643
   
   `'False'` string is not falsy for helm, so this it's not workding. Should be a plain `false`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] FloChehab commented on pull request #11675: fix pod launcher rolebinding in helm chart

Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #11675:
URL: https://github.com/apache/airflow/pull/11675#issuecomment-713407733


   Thanks @dimberman .
   How would you like to proceed for my comment above: https://github.com/apache/airflow/pull/11675#issuecomment-712741989 ? (it is working for the value above: https://github.com/apache/airflow/blob/master/chart/values.yaml#L640 but not internally for helm)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org