You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/04/29 22:43:58 UTC

Re: Review Request 32630: Add style change proposal for constant reference to temporaries.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32630/
-----------------------------------------------------------

(Updated April 29, 2015, 8:43 p.m.)


Review request for mesos, Benjamin Hindman and switched to 'mcypark'.


Repository: mesos


Description (updated)
-------

Ben suggested we start pushing proposal markdowns to the repo, so they can go through a nice review process.
This proposal is to augment the style guide to disallow capturing temporaries by reference.

Closing in favor of:
https://issues.apache.org/jira/browse/MESOS-2629
https://reviews.apache.org/r/33271


Diffs
-----

  docs/proposals/style/const_ref_to_temporary.md PRE-CREATION 

Diff: https://reviews.apache.org/r/32630/diff/


Testing
-------

The 'output' in the proposal shows the problem.


Thanks,

Joris Van Remoortere