You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Frank-Michael Jaeschke (JIRA)" <de...@myfaces.apache.org> on 2009/01/23 18:02:06 UTC
[jira] Created: (MYFACES-2139) h:messages don't use styleClass
attribute when rendering
h:messages don't use styleClass attribute when rendering
--------------------------------------------------------
Key: MYFACES-2139
URL: https://issues.apache.org/jira/browse/MYFACES-2139
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 1.1.6
Reporter: Frank-Michael Jaeschke
MyFaces breaks compatibility with Sun RI as the styleClass attribute is not rendered for h:messages.
The styleClass attribute should be applied to the <ul> element (or the <table> element if in table layout).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2139) h:messages don't use styleClass
attribute when rendering
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2139.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.7-SNAPSHOT
1.1.7-SNAPSHOT
Assignee: Leonardo Uribe
Fixed on both branches. The patch missed some points, because HtmlMessageRenderer is parent of HtmlMessagesRenderer. Thanks to Frank-Michael Jaeschke for the tips.
> h:messages don't use styleClass attribute when rendering
> --------------------------------------------------------
>
> Key: MYFACES-2139
> URL: https://issues.apache.org/jira/browse/MYFACES-2139
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 1.1.6, 1.2.6
> Reporter: Frank-Michael Jaeschke
> Assignee: Leonardo Uribe
> Fix For: 1.1.7-SNAPSHOT, 1.2.7-SNAPSHOT
>
> Attachments: HtmlRendererBase.patch
>
>
> MyFaces breaks compatibility with Sun RI as the styleClass attribute is not rendered for h:messages.
> The styleClass attribute should be applied to the <ul> element (or the <table> element if in table layout).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2139) h:messages don't use styleClass
attribute when rendering
Posted by "Frank-Michael Jaeschke (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank-Michael Jaeschke updated MYFACES-2139:
--------------------------------------------
Status: Open (was: Patch Available)
> h:messages don't use styleClass attribute when rendering
> --------------------------------------------------------
>
> Key: MYFACES-2139
> URL: https://issues.apache.org/jira/browse/MYFACES-2139
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 1.1.6
> Reporter: Frank-Michael Jaeschke
>
> MyFaces breaks compatibility with Sun RI as the styleClass attribute is not rendered for h:messages.
> The styleClass attribute should be applied to the <ul> element (or the <table> element if in table layout).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2139) h:messages don't use styleClass
attribute when rendering
Posted by "Frank-Michael Jaeschke (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713985#action_12713985 ]
Frank-Michael Jaeschke commented on MYFACES-2139:
-------------------------------------------------
I think the fix is not complete yet.
Rendering styleClass and style attributes to the component is missing.
According to sun jsf 1.1 tld doc (http://java.sun.com/javaee/javaserverfaces/1.1_01/docs/tlddocs/index.html),
for example we have
errorClass - CSS style class to apply to any message with a severity class of "ERROR"
fatalClass - CSS style class to apply to any message with a severity class of "FATAL" and so on.
A single message is rendered to
<li class="errorClass">message</li>
this is perfect now.
But tld contains also
styleClass - Space-separated list of CSS style class(es) to be applied when this element is rendered. This value must be passed through as the "class" attribute on generated markup.
So I would assume
<h:messages styleClass="styleClass" errorClass="errorClass"/>
would be rendered to
<ul class="styleClass">
<li class="errorClass">message</li>
</ul>
> h:messages don't use styleClass attribute when rendering
> --------------------------------------------------------
>
> Key: MYFACES-2139
> URL: https://issues.apache.org/jira/browse/MYFACES-2139
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 1.1.6, 1.2.6
> Reporter: Frank-Michael Jaeschke
> Assignee: Leonardo Uribe
> Fix For: 1.1.7-SNAPSHOT, 1.2.7-SNAPSHOT
>
> Attachments: HtmlRendererBase.patch
>
>
> MyFaces breaks compatibility with Sun RI as the styleClass attribute is not rendered for h:messages.
> The styleClass attribute should be applied to the <ul> element (or the <table> element if in table layout).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2139) h:messages don't use styleClass
attribute when rendering
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714106#action_12714106 ]
Leonardo Uribe commented on MYFACES-2139:
-----------------------------------------
Yes, you're right. Changed to proposed behavior on both branches and modified junit test to detect this condition. Thanks to Frank-Michael Jaeschke for the attention in the details.
> h:messages don't use styleClass attribute when rendering
> --------------------------------------------------------
>
> Key: MYFACES-2139
> URL: https://issues.apache.org/jira/browse/MYFACES-2139
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 1.1.6, 1.2.6
> Reporter: Frank-Michael Jaeschke
> Assignee: Leonardo Uribe
> Fix For: 1.1.7-SNAPSHOT, 1.2.7-SNAPSHOT
>
> Attachments: HtmlRendererBase.patch
>
>
> MyFaces breaks compatibility with Sun RI as the styleClass attribute is not rendered for h:messages.
> The styleClass attribute should be applied to the <ul> element (or the <table> element if in table layout).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2139) h:messages don't use styleClass
attribute when rendering
Posted by "Frank-Michael Jaeschke (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank-Michael Jaeschke updated MYFACES-2139:
--------------------------------------------
Status: Patch Available (was: Open)
> h:messages don't use styleClass attribute when rendering
> --------------------------------------------------------
>
> Key: MYFACES-2139
> URL: https://issues.apache.org/jira/browse/MYFACES-2139
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 1.1.6
> Reporter: Frank-Michael Jaeschke
>
> MyFaces breaks compatibility with Sun RI as the styleClass attribute is not rendered for h:messages.
> The styleClass attribute should be applied to the <ul> element (or the <table> element if in table layout).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.