[jira] [Resolved] (CASSANDRA-3921) Compaction doesn't clear out expired tombstones from SerializingCache

["Jonathan Ellis (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-3921.
---------------------------------------

    Resolution: Fixed
      Reviewer: slebresne
      Assignee: Jonathan Ellis

bq. we may want to make removeDeletedInCache be a noop for copying caches just to avoid the useless deserialization

done in 94860c6c3713cda4f17dabb2ac2ce30cfe92f6e2
                
> Compaction doesn't clear out expired tombstones from SerializingCache
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-3921
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3921
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.8.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> Compaction calls removeDeletedInCache, which looks like this:
> {code}
> .   public void removeDeletedInCache(DecoratedKey key)
>     {
>         ColumnFamily cachedRow = cfs.getRawCachedRow(key);
>         if (cachedRow != null)
>             ColumnFamilyStore.removeDeleted(cachedRow, gcBefore);
>     }
> {code}
> For the SerializingCache, this means it calls removeDeleted on a temporary, deserialized copy, which leaves the cache contents unaffected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira