You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/15 14:58:46 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #23044: Move around overflow, position and padding
bbovenzi opened a new pull request, #23044:
URL: https://github.com/apache/airflow/pull/23044
Fixes: #23042
The padding in the graph view is applied to the node and not the edge. Therefore an edge that goes above the highest node, can be cut off. Also, the autorefresh buttons creates a hidden cutoff where `overflow: hidden` style is being applied.
This fix increases the padding, makes the refresh actions absolutely positioned to prevent it from cutting off the screen, moves around which elements allow overflow or not, and then apply a transparent background to the refresh actions to make any overlap less jarring.
This moves a lot right now, so I want to make sure it works for all DAGs so we will merge this _after_ 2.3.0.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23044: Fix Graph overflow, position and padding
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23044:
URL: https://github.com/apache/airflow/pull/23044#issuecomment-1125310029
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #23044: Fix Graph overflow, position and padding
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #23044:
URL: https://github.com/apache/airflow/pull/23044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org