You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/22 15:10:49 UTC

[GitHub] [incubator-kvrocks] IoCing opened a new issue, #1204: Add disablelogclean command to close

IoCing opened a new issue, #1204:
URL: https://github.com/apache/incubator-kvrocks/issues/1204

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   At present, we can enable logclean by configuring log-retention-days. but we can't disable logclean except reboot with  set log-retention-days to -1
   
   ### Solution
   
   we can add a new command to disable logclean by calling `google::DisableLogCleaner()`.
   we also can add more options to dynamically configure log-retention-day.
   
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] IoCing closed issue #1204: Add disablelogclean command to close

Posted by GitBox <gi...@apache.org>.
IoCing closed issue #1204: Add disablelogclean command to close 
URL: https://github.com/apache/incubator-kvrocks/issues/1204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] IoCing commented on issue #1204: Add disablelogclean command to close

Posted by GitBox <gi...@apache.org>.
IoCing commented on issue #1204:
URL: https://github.com/apache/incubator-kvrocks/issues/1204#issuecomment-1363008589

   > config set log-retention-days -1
   
   oh , i get it  ,We have implemented it in the callback.
   
   I forgot the config command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1204: Add disablelogclean command to close

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #1204:
URL: https://github.com/apache/incubator-kvrocks/issues/1204#issuecomment-1362988891

   Maybe I made an oversight during the code review of #1171, since I thought that the previous PR was able to do this by `config set log-retention-days -1` in a kvrocks client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org