You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sho Shimauchi (Created) (JIRA)" <ji...@apache.org> on 2011/12/11 01:12:40 UTC

[jira] [Created] (HADOOP-7910) add configuration methods to handle human readable size values

add configuration methods to handle human readable size values
--------------------------------------------------------------

                 Key: HADOOP-7910
                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
             Project: Hadoop Common
          Issue Type: Improvement
          Components: conf
            Reporter: Sho Shimauchi
            Priority: Minor


It's better to have a new configuration methods which handle human readable size values.
For example, see HDFS-1314.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181924#comment-13181924 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #131 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/131/])
    merge HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228562
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/BlockSizeParam.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177098#comment-13177098 ] 

Hadoop QA commented on HADOOP-7910:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12508827/HADOOP-7910.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 5 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/491//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/491//console

This message is automatically generated.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177139#comment-13177139 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #909 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/909/])
    HADOOP-7910. Add Configuration.getLongBytes to handle human readable byte size values. (Sho Shimauchi via harsh)

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225489
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sho Shimauchi updated HADOOP-7910:
----------------------------------

    Attachment: HADOOP-7910.patch.3
    
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sho Shimauchi updated HADOOP-7910:
----------------------------------

    Attachment: hadoop-7910.txt
    
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177106#comment-13177106 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1551 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1551/])
    HADOOP-7910. Add Configuration.getLongBytes to handle human readable byte size values. (Sho Shimauchi via harsh)

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225489
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167019#comment-13167019 ] 

Hadoop QA commented on HADOOP-7910:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12506879/hadoop-7910.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 5 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/464//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/464//console

This message is automatically generated.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181851#comment-13181851 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1531 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1531/])
    Merged HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23, updating CHANGES.txt for trunk.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228567
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167020#comment-13167020 ] 

Sho Shimauchi commented on HADOOP-7910:
---------------------------------------

-1 javadoc seems to be existing issues from trunk. 
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7910:
----------------------------

    Status: Open  (was: Patch Available)
    
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177114#comment-13177114 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1500 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1500/])
    HADOOP-7910. Add Configuration.getLongBytes to handle human readable byte size values. (Sho Shimauchi via harsh)

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225489
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181813#comment-13181813 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Common-0.23-Commit #352 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/352/])
    merge HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228562
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/BlockSizeParam.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177172#comment-13177172 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #942 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/942/])
    HADOOP-7910. Add Configuration.getLongBytes to handle human readable byte size values. (Sho Shimauchi via harsh)

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225489
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7910:
----------------------------

    Target Version/s: 0.23.1  (was: 0.24.0)

Backporting to 0.23 for HDFS-1314.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176248#comment-13176248 ] 

Aaron T. Myers commented on HADOOP-7910:
----------------------------------------

bq. These calls will fail the test with the string as the reason, so something like "Test passed for a number too large" or "Test passed for a number too small" are more easier to understand when such a thing happens.

I also really like to include the actual values that caused the test case to fail. If I ran this test and saw this message, the very first thing I would do would be to go find the test class and add debugging output to print the actual values, and then rerun the test.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Todd Lipcon (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon reassigned HADOOP-7910:
-----------------------------------

    Assignee: Sho Shimauchi
    
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sho Shimauchi updated HADOOP-7910:
----------------------------------

    Status: Patch Available  (was: Open)
    
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181839#comment-13181839 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #363 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/363/])
    merge HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228562
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/BlockSizeParam.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175684#comment-13175684 ] 

Sho Shimauchi commented on HADOOP-7910:
---------------------------------------

Thanks Harsh, I revised the patch.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175673#comment-13175673 ] 

Harsh J commented on HADOOP-7910:
---------------------------------

This is a good addition.

Some comments on the common patch:

* Remove the TODO note, as I think it is fine if we skip the redundant "bytes" 'b' character. Instead, add to the javadocs of the getLongBytes method what is the intended input supposed to look like for the method to work fine.
* The last test, you seem to call getInt instead of getLongBytes. I don't think getLongBytes would throw a NumberFormatException, but I didn't really try. You need to fix this.

If this method has a definitive input it expects, then it would be nice if it also threw a very nice response out when it was not satisfied with the input received.

Am not sure if the underlying StringUtils method spews out a proper message users can understand (for instance, when they put in 100GB instead of 100G despite documentation of the property downstream), but would be good to have such a message as it helps when users misconfigure things up.

Could you add such an exception message and also test for it when you catch it, in your last test?

Thanks!
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181804#comment-13181804 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #342 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/342/])
    merge HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228562
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/BlockSizeParam.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177108#comment-13177108 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1479 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1479/])
    HADOOP-7910. Add Configuration.getLongBytes to handle human readable byte size values. (Sho Shimauchi via harsh)

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1225489
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181943#comment-13181943 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #153 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/153/])
    merge HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228562
Files : 
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs/src/documentation/content/xdocs/cluster_setup.xml
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestStringUtils.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/BlockSizeParam.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/.gitignore
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/FileBench.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/io/TestSequenceFileMergeProgress.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/security/authorize/TestServiceLevelAuthorization.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/test/MapredTestDriver.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181825#comment-13181825 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1584 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1584/])
    Merged HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23, updating CHANGES.txt for trunk.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228567
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181932#comment-13181932 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #918 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/918/])
    Merged HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23, updating CHANGES.txt for trunk.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228567
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7910:
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.24.0
           Status: Resolved  (was: Patch Available)

Committed revision 1225489 to trunk. Thanks for your contribution Sho!

Lets wrap this up with HDFS-1314.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sho Shimauchi updated HADOOP-7910:
----------------------------------

    Attachment: HADOOP-7910.patch

thanks for comments :)
fixed and attached
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7910:
----------------------------

    Hadoop Flags: Reviewed
          Status: Patch Available  (was: Open)

+1, and tests pass. Will commit once Hudson gives its report.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181832#comment-13181832 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1511 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1511/])
    Merged HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23, updating CHANGES.txt for trunk.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228567
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7910:
----------------------------

    Attachment: HADOOP-7910.patch

Changed a small case in exception message (s/invalid/Invalid). Attaching patch that was tested and committed.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated HADOOP-7910:
----------------------------

     Target Version/s:   (was: 0.23.1)
    Affects Version/s: 0.23.0
        Fix Version/s:     (was: 0.24.0)
                       0.23.1

Backported to 0.23.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sho Shimauchi updated HADOOP-7910:
----------------------------------

    Attachment: HADOOP-7910.patch

fixed format
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181952#comment-13181952 ] 

Hudson commented on HADOOP-7910:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #951 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/951/])
    Merged HDFS-2349, HDFS-2729, HDFS-2726, HDFS-554, HDFS-1314, HADOOP-7910 to branch-0.23, updating CHANGES.txt for trunk.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1228567
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>             Fix For: 0.23.1
>
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176104#comment-13176104 ] 

Harsh J commented on HADOOP-7910:
---------------------------------

Thanks Sho. The patch looks good. I'll commit it once the following couple of nits are addressed:

- {{fail("");}} messages such as {{"Too large number"}} is not very descriptive. These calls will fail the test with the string as the reason, so something like "Test passed for a number too large" or "Test passed for a number too small" are more easier to understand when such a thing happens. Makes sense? (You have the other fail() message correctly written, so just these last two that relate to Longs).
- The {{IllegalArgumentException}} that carries the message {{"binary prefix is allowed only k, m, g, t, p, e(case insensitive)"}} can be improved. Perhaps something more like: {{"Invalid size prefix %char in given string %string. Allowed prefixes are <set>"}}. Know that exception messages and log messages cater to users, and if we can be very clear at what's being given to them, it makes their life easier in hunting down the trouble and fixing it up themselves :)
- Javadoc for the getLongBytes method can carry a 'case insensitive' comment, for the devs.
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Sho Shimauchi (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sho Shimauchi updated HADOOP-7910:
----------------------------------

    Attachment: HADOOP-7910.patch
    
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7910) add configuration methods to handle human readable size values

Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177100#comment-13177100 ] 

Harsh J commented on HADOOP-7910:
---------------------------------

The javadoc warnings appear unrelated. Committing.

{code}
6 warnings
[WARNING] Javadoc Warnings
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1063: warning - Tag @link: can't find call(RpcKind, Writable, InetSocketAddress,
[WARNING] Class, UserGroupInformation, int, Configuration) in org.apache.hadoop.ipc.Client
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1018: warning - Tag @link: can't find call(RpcKind, Writable, ConnectionId) in org.apache.hadoop.ipc.Client
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1048: warning - Tag @link: can't find call(RpcKind, Writable, ConnectionId) in org.apache.hadoop.ipc.Client
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1031: warning - Tag @link: can't find call(RpcKind, Writable, ConnectionId) in org.apache.hadoop.ipc.Client
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1093: warning - Tag @link: can't find call(RpcKind, Writable, ConnectionId) in org.apache.hadoop.ipc.Client
[WARNING] /Users/harshchouraria/Work/code/apache/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:1007: warning - Tag @link: can't find call(RpcKind, Writable, ConnectionId) in org.apache.hadoop.ipc.Client
{code}
                
> add configuration methods to handle human readable size values
> --------------------------------------------------------------
>
>                 Key: HADOOP-7910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7910
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Sho Shimauchi
>            Assignee: Sho Shimauchi
>            Priority: Minor
>         Attachments: HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch, HADOOP-7910.patch.3, hadoop-7910.txt
>
>
> It's better to have a new configuration methods which handle human readable size values.
> For example, see HDFS-1314.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira