[jira] [Commented] (CALCITE-2695) Simplify casts which are only widening nullability

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696150#comment-16696150 ] 

Zoltan Haindrich commented on CALCITE-2695:
-------------------------------------------

opened [pr934|https://github.com/apache/calcite/pull/934]

also enabled to run simplify below cast

> Simplify casts which are only widening nullability
> --------------------------------------------------
>
>                 Key: CALCITE-2695
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2695
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>
> There are cases in which casts are added; but they are not neccessary.
> {code}
>   @Test public void testSimplifyRedundantCast() {
>     RexNode expr = cast(isTrue(vBoolNotNull()), tBoolean(true));
>     assertThat(expr.getType().isNullable(), is(true));
>     RexNode result = simplify.simplifyUnknownAs(expr, RexUnknownAs.UNKNOWN);
>     assertThat(result.getType().isNullable(), is(false));
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)