You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/29 12:51:17 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #1452: HDDS-4288. the icon of hadoop-ozone is bigger than ever
elek opened a new pull request #1452:
URL: https://github.com/apache/hadoop-ozone/pull/1452
## What changes were proposed in this pull request?
Logo is too big on doc snapshot (generated by the Jenkins):
INFRA is migrated to a new jenkins and the new Jenkins adds a more secure HTTP headers:
```
< Content-Security-Policy: sandbox; default-src 'none'; img-src 'self'; style-src 'self';
< X-WebKit-CSP: sandbox; default-src 'none'; img-src 'self'; style-src 'self';
```
IMHO the inline styles which are used in the current code are disabled:
```
<a href="{{ "index.html" | relLangURL }}" class="navbar-left" style="height: 50px; padding: 5px 10px 5px 0px;">
```
While it's not a production issue, we can move the custom styles to the css, to make it compatible with the jenkins.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4288
## How was this patch tested?
1. If you remove inline `style` attributes , and do a `hugo serve` in `hadoop-hdds/docs`, you can see that the logo is too big.
2. When you apply the patches (css based styles) the logo is fine, again.
It is supposed to be compatible with the Jenkins as all the other css based styles are working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1452: HDDS-4288. the icon of hadoop-ozone is bigger than ever
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #1452:
URL: https://github.com/apache/hadoop-ozone/pull/1452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1452: HDDS-4288. the icon of hadoop-ozone is bigger than ever
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1452:
URL: https://github.com/apache/hadoop-ozone/pull/1452#issuecomment-700910350
@elek Thanks for working on this! I noticed this weird big logo on the docs recently but didn't have the bandwidth to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org