You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andrew Jorgensen (JIRA)" <ji...@apache.org> on 2017/09/15 14:28:01 UTC
[jira] [Commented] (CASSANDRA-13006) Disable automatic heap dumps
on OOM error
[ https://issues.apache.org/jira/browse/CASSANDRA-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167937#comment-16167937 ]
Andrew Jorgensen commented on CASSANDRA-13006:
----------------------------------------------
Just to ask a clarifying question for my own understanding. This change would change the default from always producing a heap dump to having to explicitly turn it on which I think is good. One place this might trip some people up is cassandra has a command line [argument|https://github.com/apache/cassandra/blob/fe3cfe3d7df296f022c50c9c0d22f91a0fc0a217/bin/cassandra#L245-L247] that allows setting the specific location of the heap dump. One place that I know this is used is in the [debian init|https://github.com/apache/cassandra/blob/fe3cfe3d7df296f022c50c9c0d22f91a0fc0a217/debian/init#L86-L87] script. Presumably if that flag is set the user wants to get heap dumps, is it work also checking to see if -XX:HeapDumpPath or -XX:+HeapDumpOnOutOfMemoryError are present when creating a heap dump to make sure the behavior stays consistent?
I also have another change [CASSANDRA-13843|https://issues.apache.org/jira/browse/CASSANDRA-13843] that I am proposing to fix the debian init script since it shadows the HeapDumpPath environment variable and renders it unchangeable from the default in its current form.
> Disable automatic heap dumps on OOM error
> -----------------------------------------
>
> Key: CASSANDRA-13006
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13006
> Project: Cassandra
> Issue Type: Bug
> Components: Configuration
> Reporter: anmols
> Assignee: Benjamin Lerer
> Priority: Minor
> Fix For: 3.0.9
>
> Attachments: 13006-3.0.9.txt
>
>
> With CASSANDRA-9861, a change was added to enable collecting heap dumps by default if the process encountered an OOM error. These heap dumps are stored in the Apache Cassandra home directory unless configured otherwise (see [Cassandra Support Document|https://support.datastax.com/hc/en-us/articles/204225959-Generating-and-Analyzing-Heap-Dumps] for this feature).
>
> The creation and storage of heap dumps aides debugging and investigative workflows, but is not be desirable for a production environment where these heap dumps may occupy a large amount of disk space and require manual intervention for cleanups.
>
> Managing heap dumps on out of memory errors and configuring the paths for these heap dumps are available as JVM options in JVM. The current behavior conflicts with the Boolean JVM flag HeapDumpOnOutOfMemoryError.
>
> A patch can be proposed here that would make the heap dump on OOM error honor the HeapDumpOnOutOfMemoryError flag. Users who would want to still generate heap dumps on OOM errors can set the -XX:+HeapDumpOnOutOfMemoryError JVM option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org