You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/10 16:29:03 UTC

[GitHub] [incubator-gobblin] haojiliu opened a new pull request #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log

haojiliu opened a new pull request #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log
URL: https://github.com/apache/incubator-gobblin/pull/2953
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1111
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   raw data might contain PII information. During testing, user sensitive data will be collected and stored in the logs. This is a data privacy risk, and is also polluting the log as we are printing out every single line of record read in.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   No testing as it's code deletion. Build succeeded.
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] yukuai518 commented on issue #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log

Posted by GitBox <gi...@apache.org>.
yukuai518 commented on issue #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log
URL: https://github.com/apache/incubator-gobblin/pull/2953#issuecomment-612158836
 
 
   + 1 LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-gobblin] asfgit closed pull request #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2953: [GOBBLIN-1111] CsvToJsonConverterV2 should not print raw data in log
URL: https://github.com/apache/incubator-gobblin/pull/2953
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services