Change in asterixdb[master]: [NO ISSUE][ING] Cleanup active listener

["abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>]

abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][ING] Cleanup active listener
......................................................................


Patch Set 7:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2618/7/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java
File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActivityState.java:

PS7, Line 39:  The activity has been started successfully and is running
> fix
Done


https://asterix-gerrit.ics.uci.edu/#/c/2618/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java:

PS7, Line 175:             if (numRegistered == locations.getLocations().length && state != ActivityState.CANCELLING) {
> refactor into a single method
Done


PS7, Line 196: !jobStatus.equals(JobStatus.TERMINATED)
> isSuccessfullyTerminated
Done


PS7, Line 394: else {
> refactor the else
Done


PS7, Line 399: } catch (Throwable th) {
             :                     ExitUtil.halt(ExitUtil.EC_FAILED_TO_CANCEL_ACTIVE_START_STOP);
             :                 }
> remove
Done


Line 420:         } catch (Throwable th) {
> BLOCKER SonarQube violation:
Done


PS7, Line 446: if (!subscriber.isDone()) {
             :                 cancelJobSafely(metadataProvider, e);
             :                 final Span span = Span.start(2, TimeUnit.MINUTES);
             :                 InvokeUtil.doUninterruptibly(() -> {
             :                     if (!subscriber.sync(span)) {
             :                         ExitUtil.halt(ExitUtil.EC_FAILED_TO_CANCEL_ACTIVE_START_STOP);
             :                     }
             :                 });
             :             }
> refactor into a method and use with connect to
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2618
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f3b14aec46728fbe8b256b915d0e30992b2fe47
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: Yes