You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dblotsky <gi...@git.apache.org> on 2015/04/18 00:02:58 UTC
[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-medic/pull/44
[CB-8803] Properly fixing the intermittent cleanup issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic CB-8803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit a7b848c1a3d40430d0bd748a94d0e1c9133504ab
Author: Dmitry Blotsky <dm...@gmail.com>
Date: 2015-04-17T21:34:52Z
[CB-8803] Properly fixing the intermittent cleanup issue.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/44#discussion_r28638738
--- Diff: bin/medic.js ---
@@ -0,0 +1,110 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+"use strict";
+
+// node dependencies
+var fs = require("fs");
+var os = require("os");
+
+// external dependencies
+var shelljs = require("shelljs");
+var optimist = require("optimist");
+
+// constants
+var MAX_REMOVAL_ATTEMPTS = 3;
+
+// parse args
+var argv = optimist
+ .usage("Usage: $0 [command]")
+ .demand(1)
+ .argv;
+
+// helpers
+function fatal(message) {
+ console.error("ERROR: " + message);
+ process.exit(1);
+}
+
+function isWindows() {
--- End diff --
Dead code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/44#discussion_r28638999
--- Diff: bin/medic.js ---
@@ -0,0 +1,110 @@
+#!/usr/bin/env node
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+"use strict";
+
+// node dependencies
+var fs = require("fs");
+var os = require("os");
+
+// external dependencies
+var shelljs = require("shelljs");
+var optimist = require("optimist");
+
+// constants
+var MAX_REMOVAL_ATTEMPTS = 3;
+
+// parse args
+var argv = optimist
+ .usage("Usage: $0 [command]")
+ .demand(1)
+ .argv;
+
+// helpers
+function fatal(message) {
+ console.error("ERROR: " + message);
+ process.exit(1);
+}
+
+function isWindows() {
--- End diff --
Removed. It will be used in the next PR, and indeed it belongs there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...
Posted by dmitriy-barkalov <gi...@git.apache.org>.
Github user dmitriy-barkalov commented on the pull request:
https://github.com/apache/cordova-medic/pull/44#issuecomment-94609690
LGTM
Successfully run medic build several times
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org