You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/08/18 21:41:28 UTC
Review Request 24813: Add a job update controller interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-613
https://issues.apache.org/jira/browse/AURORA-613
Repository: aurora
Description
-------
Add a job update controller interface.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java PRE-CREATION
Diff: https://reviews.apache.org/r/24813/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 24813: Add a job update controller interface.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/
-----------------------------------------------------------
(Updated Aug. 18, 2014, 9:19 p.m.)
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-613
https://issues.apache.org/jira/browse/AURORA-613
Repository: aurora
Description
-------
Add a job update controller interface.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java PRE-CREATION
Diff: https://reviews.apache.org/r/24813/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 24813: Add a job update controller interface.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 18, 2014, 9:14 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 64
> > <https://reviews.apache.org/r/24813/diff/1/?file=662707#file662707line64>
> >
> > s/../.
Fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/#review50935
-----------------------------------------------------------
On Aug. 18, 2014, 7:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24813/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 7:41 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-613
> https://issues.apache.org/jira/browse/AURORA-613
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a job update controller interface.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 24813: Add a job update controller interface.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24813/#review50935
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java
<https://reviews.apache.org/r/24813/#comment88819>
s/../.
- Maxim Khutornenko
On Aug. 18, 2014, 7:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24813/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 7:41 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-613
> https://issues.apache.org/jira/browse/AURORA-613
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add a job update controller interface.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/updater/UpdateStateException.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24813/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>