[GitHub] spark pull request #16330: [SPARK-18817][SPARKR][SQL] change derby log outpu...

[shivaram <gi...@git.apache.org>]

Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16330#discussion_r105545530
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -2897,6 +2898,27 @@ test_that("Collect on DataFrame when NAs exists at the top of a timestamp column
       expect_equal(class(ldf3$col3), c("POSIXct", "POSIXt"))
     })
     
    +compare_list <- function(list1, list2) {
    +  # get testthat to show the diff by first making the 2 lists equal in length
    +  expect_equal(length(list1), length(list2))
    +  l <- max(length(list1), length(list2))
    --- End diff --
    
    The lengths should be equal if we get to this line ? Or am I missing something ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org