You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/11/05 16:39:00 UTC

[jira] [Commented] (ARTEMIS-2974) Audit logger can print wrong user info

    [ https://issues.apache.org/jira/browse/ARTEMIS-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226813#comment-17226813 ] 

ASF subversion and git services commented on ARTEMIS-2974:
----------------------------------------------------------

Commit ecead9b130f84e4fc2ee24045817b8a4080c613e in activemq-artemis's branch refs/heads/master from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ecead9b ]

ARTEMIS-2974 audit logger can print wrong user info

Using a ThreadLocal for the audit user information works in most cases,
but it can fail when dispatching messages to consumers because threads
are taken out of a pool to do the dispatching and those threads may not
be associated with the proper credentials. This commit fixes that
problem with the following changes:

 - Passes the Subject explicitly when logging audit info during dispatch
 - Relocates security audit logging from the SecurityManager
implementation(s) to the SecurityStore implementation
 - Associates the Subject with the connection properly with the new
security caching


> Audit logger can print wrong user info
> --------------------------------------
>
>                 Key: ARTEMIS-2974
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2974
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When dispatching messages to consumer the audit logger may print the wrong user info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)