[GitHub] [iceberg] edgarRd commented on a change in pull request #1640: Allow loading custom Catalog implementation in Spark and Flink

[GitBox <gi...@apache.org>]

edgarRd commented on a change in pull request #1640:
URL: https://github.com/apache/iceberg/pull/1640#discussion_r511051428



##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java
##########
@@ -79,6 +80,10 @@ protected CatalogLoader createCatalogLoader(String name, Map<String, String> pro
         String warehouseLocation = properties.get(HADOOP_WAREHOUSE_LOCATION);
         return CatalogLoader.hadoop(name, hadoopConf, warehouseLocation);
 
+      case "custom":

Review comment:
       Maybe we should make them an `Enum`, which in general are preferred for using in `switch` statements. Also, I'm not sure if we make sure properties are lower case for this switch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org