You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/02/18 13:42:00 UTC

[jira] [Comment Edited] (FLINK-16147) Add watermarkExprOutputType in WatermarkSpec#toString method

    [ https://issues.apache.org/jira/browse/FLINK-16147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039088#com-ent-17039088 ] 

Jark Wu edited comment on FLINK-16147 at 2/18/20 1:41 PM:
----------------------------------------------------------

Sounds good to me. Let's add {{"WatermarkSpec{...}"}} around it too. 


was (Author: jark):
Sounds good to me. Let's add "WatermarkSpec{...}" around it too. 

> Add watermarkExprOutputType in WatermarkSpec#toString method
> ------------------------------------------------------------
>
>                 Key: FLINK-16147
>                 URL: https://issues.apa#he.org/jira/browse/FLINK-16147
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Common
>    Affects Versions: 1.10.0
>            Reporter: hailong wang
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> WatermarkSpec#toString only include rowtimeAttribute and watermarkExpressionString.
> Maybe we should inlcude watermarkExprOutputType too, just like:
> {code:java}
> @Override
> public String toString() {
>    return "rowtime: '" + rowtimeAttribute k '\'' +
>       ", watermark: '" + watermarkExpressionString + '\'' +
>       ", outputType: '" + watermarkExprOutputType + '\'';
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)