[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #399: HDDS-2424. Add the recover-trash command server side handling.

[GitBox <gi...@apache.org>]

maobaolong commented on a change in pull request #399: HDDS-2424. Add the recover-trash command server side handling.
URL: https://github.com/apache/hadoop-ozone/pull/399#discussion_r361884516
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
 ##########
 @@ -871,6 +871,19 @@ private boolean isKeyEmpty(OmKeyInfo keyInfo) {
      startKeyName, keyPrefix, maxKeys);
   }
 
+  @Override
+  public boolean recoverTrash(String volumeName, String bucketName,
+      String keyName, String destinationBucket) throws IOException {
+
+    Preconditions.checkNotNull(volumeName);
 
 Review comment:
   Not sure the @Nonnull is a better way? I saw the Nonnull annotation in the  hadoop-ozone project already, and findbugs will find null argument during build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org