You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by eolivelli <gi...@git.apache.org> on 2018/05/20 13:53:59 UTC
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/524
ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails on Linux box: Unable to parse:includedir /etc/krb5.conf.d/
Fixes QuorumKerberosHostBasedAuthTest, see ZOOKEEPER-3043
- upgrade Kerby to 1.0.0
- upgrade commons-io to 2.5, needed by Kerby
- fix test dir in KerberosTestUtils
This should be also cherry-picked to 3.5 branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper fix/ZOOKEEPER-3043
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #524
----
commit e224e823e7eddc9ed42b1bdf1b20f2fe66eec7f7
Author: Enrico Olivelli <eo...@...>
Date: 2018-05-20T13:51:12Z
QuorumKerberosHostBasedAuthTest fails on Linux box: Unable to parse:includedir /etc/krb5.conf.d/
- upgrade Kerby to 1.0.0
- upgrade commons-io to 2.5, needed by Kerby
- fix test dir in KerberosTestUtils
----
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/524
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189660714
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="jackson-mapper-asl.version" value="1.9.11"/>
<property name="dependency-check-ant.version" value="2.1.0"/>
- <property name="commons-io.version" value="2.4"/>
- <property name="kerby.version" value="1.0.0-RC2"/>
+ <property name="commons-io.version" value="2.5"/>
+ <property name="kerby.version" value="1.0.0"/>
--- End diff --
Because it is not available for all submodules of Kerby, it would make the patch more complex.
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189661074
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="jackson-mapper-asl.version" value="1.9.11"/>
<property name="dependency-check-ant.version" value="2.1.0"/>
- <property name="commons-io.version" value="2.4"/>
- <property name="kerby.version" value="1.0.0-RC2"/>
+ <property name="commons-io.version" value="2.5"/>
--- End diff --
It is the only requirement for Kerby. Will update to 2.6
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189658262
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="jackson-mapper-asl.version" value="1.9.11"/>
<property name="dependency-check-ant.version" value="2.1.0"/>
- <property name="commons-io.version" value="2.4"/>
- <property name="kerby.version" value="1.0.0-RC2"/>
+ <property name="commons-io.version" value="2.5"/>
--- End diff --
2.6 is available - why not update to that?
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189664272
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="jackson-mapper-asl.version" value="1.9.11"/>
<property name="dependency-check-ant.version" value="2.1.0"/>
- <property name="commons-io.version" value="2.4"/>
- <property name="kerby.version" value="1.0.0-RC2"/>
+ <property name="commons-io.version" value="2.5"/>
+ <property name="kerby.version" value="1.0.0"/>
--- End diff --
Changing to 1.1.0 worked for me - it compiled and the tests ran. Is there something else?
I did try 1.1.1 but that had the issue you mentioned.
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
I will send another patch for 3.4.
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
Maybe I tried 1.1.1 will send patch tomorrow.
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
@phunt
Patch on branch 3.4 #532
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
retest this please
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189658310
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="jackson-mapper-asl.version" value="1.9.11"/>
<property name="dependency-check-ant.version" value="2.1.0"/>
- <property name="commons-io.version" value="2.4"/>
- <property name="kerby.version" value="1.0.0-RC2"/>
+ <property name="commons-io.version" value="2.5"/>
+ <property name="kerby.version" value="1.0.0"/>
--- End diff --
1.1.0 is available - why not update to that?
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
@phunt
I have cleaned up.
I did a 'git commit -a' by mistake.
I am preparing patch for 3.4
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/524
FYI this doesn't apply cleanly to branch-3.4, you'll have to submit a separate PR if you want to fix that branch as well. (it does apply cleanly to branch 3.5 though)
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/524
@phunt patch ready for master
---
[GitHub] zookeeper pull request #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/524#discussion_r189661235
--- Diff: build.xml ---
@@ -55,8 +55,8 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="jackson-mapper-asl.version" value="1.9.11"/>
<property name="dependency-check-ant.version" value="2.1.0"/>
- <property name="commons-io.version" value="2.4"/>
- <property name="kerby.version" value="1.0.0-RC2"/>
+ <property name="commons-io.version" value="2.5"/>
+ <property name="kerby.version" value="1.0.0"/>
--- End diff --
I will try again to update to 1.1.0
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/524
+1, lgtm. Thanks @eolivelli
---
[GitHub] zookeeper issue #524: ZOOKEEPER-3043: QuorumKerberosHostBasedAuthTest fails ...
Posted by phunt <gi...@git.apache.org>.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/524
@eolivelli something seems borked - there are 8 changed files, many of which seem unrelated to the issue. Perhaps you pulled in some unexpected changes accidentally?
---