You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/10/01 04:45:56 UTC

[GitHub] [kvrocks] git-hulk commented on pull request #1790: Fix data race in instant metrics

git-hulk commented on PR #1790:
URL: https://github.com/apache/kvrocks/pull/1790#issuecomment-1741956805

   > I am not sure if we can just disable these two function in TSAN since maybe we can bear some data race here.
   
   Yes, that's a nice solution as well. `GetInstantaneousMetric` only be used in the info command and those values are inside memory, so I guess it'd be good to have a read lock here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org