You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by pmouawad <gi...@git.apache.org> on 2017/05/02 06:41:08 UTC
[GitHub] commons-compress pull request #23: Add Brotli Support
GitHub user pmouawad opened a pull request:
https://github.com/apache/commons-compress/pull/23
Add Brotli Support
Fix for:
https://issues.apache.org/jira/browse/COMPRESS-392
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pmouawad/commons-compress BROTLI_SUPPORT
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 3763178324921dc4110d683682b341f2d2e0fd5e
Author: pmouawad <p....@ubik-ingenierie.com>
Date: 2017-05-02T06:37:26Z
Add Brotli Support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #23: Add Brotli Support
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/23
[](https://coveralls.io/builds/11329901)
Coverage decreased (-0.08%) to 84.208% when pulling **9cc8918f25ec1f51dd8a5dda07d5e236209b4b3b on pmouawad:BROTLI_SUPPORT** into **65184bc08140c7695ed6b39aa0e77b0dba61be92 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #23: Add Brotli Support
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/23
Many thanks Philippe
see my comments on the test.
Also I haven't checked whether the brotli lib is an OSGi bundle, we may need to update the bundle-plugin configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #23: Add Brotli Support
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/23
[](https://coveralls.io/builds/11327289)
Coverage decreased (-0.09%) to 84.202% when pulling **3763178324921dc4110d683682b341f2d2e0fd5e on pmouawad:BROTLI_SUPPORT** into **65184bc08140c7695ed6b39aa0e77b0dba61be92 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #23: Add Brotli Support
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/23#discussion_r114257946
--- Diff: pom.xml ---
@@ -68,6 +68,12 @@ jar, tar, zip, dump, 7z, arj.
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.brotli</groupId>
+ <artifactId>dec</artifactId>
+ <version>0.1.1</version>
+ <scope>compile</scope>
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #23: Add Brotli Support
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-compress/pull/23
Thank you for your patch. The only thing missing at first glance is a patch to `org.apache.commons.compress.compressors.CompressorStreamFactory`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #23: Add Brotli Support
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/23
[](https://coveralls.io/builds/11327484)
Coverage decreased (-0.09%) to 84.202% when pulling **522b6c67c28f2bcb0d9b09fd47b10449cb1c578c on pmouawad:BROTLI_SUPPORT** into **65184bc08140c7695ed6b39aa0e77b0dba61be92 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #23: Add Brotli Support
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/23#discussion_r114257473
--- Diff: pom.xml ---
@@ -85,6 +91,13 @@ jar, tar, zip, dump, 7z, arj.
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>commons-codec</groupId>
+ <artifactId>commons-codec</artifactId>
+ <version>1.10</version>
+ <scope>test</scope>
+ </dependency>
+
--- End diff --
I'd prefer encoding things by hand rather than adding a new dependency just for tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #23: Add Brotli Support
Posted by bindul <gi...@git.apache.org>.
Github user bindul commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/23#discussion_r114257132
--- Diff: pom.xml ---
@@ -68,6 +68,12 @@ jar, tar, zip, dump, 7z, arj.
<scope>test</scope>
</dependency>
<dependency>
+ <groupId>org.brotli</groupId>
+ <artifactId>dec</artifactId>
+ <version>0.1.1</version>
+ <scope>compile</scope>
--- End diff --
Shouldn't this be an optional dependency, just like the xz one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #23: Add Brotli Support
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/23
[](https://coveralls.io/builds/11328000)
Coverage decreased (-0.07%) to 84.218% when pulling **fde11cf4c1956bbe78d7dc7efb78db2d66a53da7 on pmouawad:BROTLI_SUPPORT** into **65184bc08140c7695ed6b39aa0e77b0dba61be92 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #23: Add Brotli Support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org