You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/20 07:40:39 UTC
[GitHub] [doris] 924060929 commented on a diff in pull request #10667: [Enhancement](Nereids) add some expr rewrite rule and plan rewrite rule of rewrite its expression
924060929 commented on code in PR #10667:
URL: https://github.com/apache/doris/pull/10667#discussion_r925257955
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionOfPlanRewrite.java:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rewrite;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.rules.rewrite.RewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * expression of plan rewrite rule.
+ */
+public class ExpressionOfPlanRewrite implements RewriteRuleFactory {
+ private final ExpressionRuleExecutor rewriter;
+
+ public ExpressionOfPlanRewrite(ExpressionRuleExecutor rewriter) {
+ this.rewriter = Objects.requireNonNull(rewriter, "rewriter is null");
+ }
+
+ @Override
+ public List<Rule<Plan>> buildRules() {
+ return ImmutableList.of(
+ new ProjectExpressionRewrite().build(),
+ new AggExpressionRewrite().build(),
+ new FilterExpressionRewrite().build(),
+ new JoinExpressionRewrite().build());
+ }
+
+
+ private class ProjectExpressionRewrite extends OneRewriteRuleFactory {
+ @Override
+ public Rule<Plan> build() {
+ return logicalProject().then(project -> {
+ List<NamedExpression> origin = project.getProjects();
+ List<NamedExpression> newProjects = origin.stream()
+ .map(expr -> (NamedExpression) rewriter.rewrite(expr)).collect(Collectors.toList());
+ return new LogicalProject<>(newProjects, project.child());
+ }).toRule(RuleType.REWRITE_PROJECT_EXPRESSION);
+ }
+ }
+
+ private class FilterExpressionRewrite extends OneRewriteRuleFactory {
+ @Override
+ public Rule<Plan> build() {
+ return logicalFilter().then(filter -> {
+ Expression newExpr = rewriter.rewrite(filter.getPredicates());
+ if (newExpr.equals(filter.getPredicates())) {
+ return filter;
+ }
+ return new LogicalFilter<>(newExpr, filter.child());
+ }).toRule(RuleType.REWRITE_FILTER_EXPRESSION);
+ }
+ }
+
+ private class AggExpressionRewrite extends OneRewriteRuleFactory {
+ @Override
+ public Rule<Plan> build() {
+ return logicalAggregate().then(agg -> {
+ List<Expression> groupByExprs = agg.getGroupByExpressionList();
+ List<Expression> newGroupByExprs = rewriter.rewrite(groupByExprs);
+
+ List<NamedExpression> outputExpressions = agg.getOutputExpressionList();
+ List<NamedExpression> newOutputExpressions = outputExpressions.stream()
Review Comment:
need check groupByExprs and newGroupByExprs not change and return origin aggregate?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionOfPlanRewrite.java:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.expression.rewrite;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.rules.rewrite.RewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate;
+import org.apache.doris.nereids.trees.plans.logical.LogicalFilter;
+import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * expression of plan rewrite rule.
+ */
+public class ExpressionOfPlanRewrite implements RewriteRuleFactory {
+ private final ExpressionRuleExecutor rewriter;
+
+ public ExpressionOfPlanRewrite(ExpressionRuleExecutor rewriter) {
+ this.rewriter = Objects.requireNonNull(rewriter, "rewriter is null");
+ }
+
+ @Override
+ public List<Rule<Plan>> buildRules() {
+ return ImmutableList.of(
+ new ProjectExpressionRewrite().build(),
+ new AggExpressionRewrite().build(),
+ new FilterExpressionRewrite().build(),
+ new JoinExpressionRewrite().build());
+ }
+
+
+ private class ProjectExpressionRewrite extends OneRewriteRuleFactory {
+ @Override
+ public Rule<Plan> build() {
+ return logicalProject().then(project -> {
+ List<NamedExpression> origin = project.getProjects();
+ List<NamedExpression> newProjects = origin.stream()
+ .map(expr -> (NamedExpression) rewriter.rewrite(expr)).collect(Collectors.toList());
+ return new LogicalProject<>(newProjects, project.child());
Review Comment:
need check expression not change and return origin project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org