You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2018/08/08 15:33:06 UTC
[2/5] activemq-artemis git commit: NO-JIRA fix flaky test
QueueControlTest#testListMessagesWithNullFilter
NO-JIRA fix flaky test QueueControlTest#testListMessagesWithNullFilter
The below error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.
java.lang.AssertionError:
Expected :2
Actual :1
[...]
at org.junit.Assert.assertEquals(Assert.java:542)
at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testListMessagesWithNullFilter(QueueControlTest.java:804)
(cherry picked from commit fbb622ae6976209a0d2d4ec1852ca8b91c4cf1e9)
Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/2fdcc9f1
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/2fdcc9f1
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/2fdcc9f1
Branch: refs/heads/2.6.x
Commit: 2fdcc9f1e059ee9e7a139de9471e1f12f5f916b7
Parents: 96421f6
Author: Jiri Danek <jd...@redhat.com>
Authored: Tue Aug 7 16:59:30 2018 +0200
Committer: Clebert Suconic <cl...@apache.org>
Committed: Wed Aug 8 11:32:26 2018 -0400
----------------------------------------------------------------------
.../artemis/tests/integration/management/QueueControlTest.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/2fdcc9f1/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
index 8eb6e03..fb0a3e5 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
@@ -800,13 +800,11 @@ public class QueueControlTest extends ManagementTestBase {
producer.send(session.createMessage(durable));
producer.send(session.createMessage(durable));
- Map<String, Object>[] messages = queueControl.listMessages(null);
- Assert.assertEquals(2, messages.length);
+ Wait.assertEquals(2, () -> queueControl.listMessages(null).length);
consumeMessages(2, session, queue);
- messages = queueControl.listMessages(null);
- Assert.assertEquals(0, messages.length);
+ Wait.assertEquals(0, () -> queueControl.listMessages(null).length);
session.deleteQueue(queue);
}