You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/03/23 07:30:12 UTC

[GitHub] [pulsar] lhotari opened a new issue, #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

lhotari opened a new issue, #19905:
URL: https://github.com/apache/pulsar/issues/19905

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Version
   
   master
   
   ### Minimal reproduce step
   
   - create a PR with changes to pulsar-function-go which break the build
   - add a commit outside of pulsar-function-go
   - the CI build passes successfully and makes the PR mergable
   
   ### What did you expect to see?
   
   - if the pulsar-function-go job fails for the PR, it shouldn't make the CI build mergable
   
   ### What did you see instead?
   
   - the PR was mergable
   
   ### Anything else?
   
   This is a known limitation of the way how the GitHub Actions workflow ci-go-functions.yaml has been configured to trigger for changes to `pulsar-function-go/**` path
   
   ```
   on:
     pull_request:
       branches:
         - master
       paths:
         - '.github/workflows/**'
         - 'pulsar-function-go/**'
     workflow_dispatch:
   ```
   
   the problem would be fixed by using `apache/pulsar-test-infra/paths-filter@master` for detecting changed files in `ci-go-functions.yaml`.
   
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #19905:
URL: https://github.com/apache/pulsar/issues/19905#issuecomment-1519309967

   Closing..
   
   Feel free to reopen if there is a live demo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #19905:
URL: https://github.com/apache/pulsar/issues/19905#issuecomment-1497008497

   Weird. Does GitHub Actions fileter paths only for the last commit? This should be a bug for the GHA side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #19905:
URL: https://github.com/apache/pulsar/issues/19905#issuecomment-1501840947

   @lhotari any feedback or new instance? I don't find a similar case now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun closed issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files
URL: https://github.com/apache/pulsar/issues/19905


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #19905:
URL: https://github.com/apache/pulsar/issues/19905#issuecomment-1497018351

   * https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#git-diff-comparisons
   
   > Pull requests: Three-dot diffs are a comparison between the most recent version of the topic branch and the commit where the topic branch was last synced with the base branch.
   
   From the doc the workflow should run because the diff is counted from the latest version to the most recent base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on issue #19905: [Bug][CI] pulsar-function-go build failures are ignored when the last commit in the PR doesn't modify go files

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #19905:
URL: https://github.com/apache/pulsar/issues/19905#issuecomment-1486993365

   > it shouldn't make the CI build mergable
   
   Then we may always run the workflow.
   
   https://github.com/apache/pulsar/blob/7a99e74220bdff7a0dff3dbbf3befb2316f3a6c8/.asf.yaml#L52
   
   Currently, only the `pulsar-ci.yml` workflow is required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org