You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by keithbranton <gi...@git.apache.org> on 2015/03/31 22:42:22 UTC
[GitHub] tomcat-maven-plugin pull request: Allow port reuse when invoking p...
GitHub user keithbranton opened a pull request:
https://github.com/apache/tomcat-maven-plugin/pull/17
Allow port reuse when invoking plugin repeatedly in build
In a multi-module build the tomcat7-maven-plugin can only be invoked once with a given port before encountering errors due to ports being bound. Calling destroy after calling stop on the embedded instances solves this problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/overstock/tomcat-maven-plugin trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat-maven-plugin/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 878e3a983b6798fb5cb541b02aaf5f56a1ef038c
Author: Keith Branton <gi...@branton.co.uk>
Date: 2015-03-31T20:38:04Z
Call destroy method on tomcat instances
Multi-module maven builds with several invocations of the tomcat7-maven-plugin are problematic because the ports from the first invokation remain bound. Calling destroy solves this.
commit 504694b572ff3f58182daac112ad7cb286df307d
Author: Keith Branton <gi...@branton.co.uk>
Date: 2015-03-31T20:39:27Z
Merge pull request #1 from overstock/port-reuse-patch
Call destroy method on tomcat instances
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: Allow port reuse when invoking p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat-maven-plugin/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org