You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2023/06/07 18:45:24 UTC
[GitHub] [airflow] amoghrajesh opened a new pull request, #31779: Supporting extraAnnotions at pgbouncer deployment level
amoghrajesh opened a new pull request, #31779:
URL: https://github.com/apache/airflow/pull/31779
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Adds support for integrating extraAnnotations in the pgbouncer deployment spec when defined in values.yaml during setup
closes: #27246
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #31779:
URL: https://github.com/apache/airflow/pull/31779#issuecomment-1601120281
I don't see any reason to have 2 ways to set annotations on the pod, and `podAnnotations` is how it's done elsewhere. `extraAnnotations` is just used on our services.
I've marked that issue as closed by #30168. Thanks @amoghrajesh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham closed pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
URL: https://github.com/apache/airflow/pull/31779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #31779:
URL: https://github.com/apache/airflow/pull/31779#issuecomment-1592324935
@jedcunningham I was trying to cover up the tech debt due to thseparatePR: https://github.com/apache/airflow/pull/27247
Not sure about the exact intention but looks like an effort to seperate the annotations into `podAnnotations` and `extraAnnotations`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #31779:
URL: https://github.com/apache/airflow/pull/31779#issuecomment-1586131571
@jedcunningham can I get a review on this once you have some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #31779:
URL: https://github.com/apache/airflow/pull/31779#issuecomment-1590385206
How is this different than `pgbouncer.podAnnotations`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on pull request #31779: Supporting extraAnnotions at pgbouncer deployment level
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #31779:
URL: https://github.com/apache/airflow/pull/31779#issuecomment-1588630050
@potiuk @jedcunningham can I get a review on this PR if you have some free time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org