You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/07 18:13:08 UTC
[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #17993: fix
R error; backport 1 line from #17228
ChaiBapchya opened a new pull request #17993: fix R error; backport 1 line from #17228
URL: https://github.com/apache/incubator-mxnet/pull/17993
Fix setRefClass not found issue by adding import of library `methods`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17993: fix R error;
backport 1 line from #17228
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17993: fix R error; backport 1 line from #17228
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-610541518
Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, unix-gpu, website, centos-cpu, sanity, windows-cpu, windows-gpu, unix-cpu, miscellaneous, edge, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17993: [R][v1.6.x]
Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611876080
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request
#17993: [R][v1.6.x] Fix blocked pipelines [windows, unix-cpu,
unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#discussion_r406848301
##########
File path: tests/python/quantization/test_quantization.py
##########
@@ -178,7 +178,7 @@ def check_requantize_with_symbol(shape, min_calib_range=None, max_calib_range=No
max_range.asscalar(),
min_calib_range=min_calib_range,
max_calib_range=max_calib_range)
- assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
+ assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np, atol = 1)
Review comment:
Flaky test test_quantization_mkldnn.test_requantize_int32_to_int8 it failed on 1 of the builds. So I retriggered it. But also added that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#17993: [R][v1.6.x] Fix blocked pipelines [windows, unix-cpu,
unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#discussion_r406846003
##########
File path: tests/python/quantization/test_quantization.py
##########
@@ -178,7 +178,7 @@ def check_requantize_with_symbol(shape, min_calib_range=None, max_calib_range=No
max_range.asscalar(),
min_calib_range=min_calib_range,
max_calib_range=max_calib_range)
- assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
+ assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np, atol = 1)
Review comment:
Why the change here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix setRefClass function not found error
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix setRefClass function not found error
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611203240
Cherrypicking Python2 -> Python3 related PRs I found after doing a git diff between v1.6.x branch and master
https://github.com/apache/incubator-mxnet/compare/v1.6.x...ChaiBapchya:master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17993: [R][v1.6.x] Fix
blocked pipelines [windows, unix-cpu, unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611556494
@lanking520 @zachgk any idea about the Scala failures? http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-17993/4/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611829126
Fixes #18005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611692592
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17993: [R][v1.6.x]
Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611332254
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611876059
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611332207
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993: fix R
error; backport 1 line from #17228
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: fix R error; backport 1 line from #17228
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-610542718
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request
#17993: [R][v1.6.x] Fix blocked pipelines [windows, unix-cpu,
unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#discussion_r406848301
##########
File path: tests/python/quantization/test_quantization.py
##########
@@ -178,7 +178,7 @@ def check_requantize_with_symbol(shape, min_calib_range=None, max_calib_range=No
max_range.asscalar(),
min_calib_range=min_calib_range,
max_calib_range=max_calib_range)
- assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
+ assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np, atol = 1)
Review comment:
Flaky test test_quantization_mkldnn.test_requantize_int32_to_int8 it failed on 1 of the builds. So I retriggered it. This change is a fix to that flaky test I cherrypicked it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zixuanweeei commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611920109
Just a reminder: https://github.com/apache/incubator-mxnet/issues/11747#issuecomment-611913307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611332576
So as it turns out, it wasn't needed to cherrypick previous PRs.
Because even without migrating CI from Py2 to Py3 docs test pass
@aaronmarkham @leezu @aaronmarkham
Plz review/merge. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix setRefClass function not found error
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix setRefClass function not found error
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611025640
Testing this locally, able to reproduce the docs error
```
Loading mxnet
[1] "Loading local: inst/libs/libmxnet.so"
<simpleError in find.package(package, lib.loc, verbose = verbose): there is no package called 'mxnet'
>
[1] "Loading local: src/mxnet.so"
<simpleError in find.package(package, lib.loc, verbose = verbose): there is no package called 'mxnet'
>
Error in loadModule("mxnet", TRUE) : could not find function "loadModule"
Calls: <Anonymous> ... load_code -> <Anonymous> -> run_pkg_hook -> <Anonymous>
Execution halted
```
However, upon checking the local files, both mxnet.so and libmxnet.so exist.
So `dyn.load` isn't able to find package
```
> ls R-package/inst/libs/
libmxnet.so
```
```
> ls R-package/src/
libmxnet.so
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix blocked pipelines [windows, unix-cpu, unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-612115651
@sandeep-krishnamurthy @zixuanweeei @leezu @aaronmarkham Pl help review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17993: [R][v1.6.x]
Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611692662
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#17993: [R][v1.6.x] Fix blocked pipelines [windows, unix-cpu,
unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#discussion_r406852516
##########
File path: tests/python/quantization/test_quantization.py
##########
@@ -178,7 +178,7 @@ def check_requantize_with_symbol(shape, min_calib_range=None, max_calib_range=No
max_range.asscalar(),
min_calib_range=min_calib_range,
max_calib_range=max_calib_range)
- assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np)
+ assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np, atol = 1)
Review comment:
Reference https://github.com/apache/incubator-mxnet/pull/16709
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611862385
It's weird why 1.6 branch is facing rvm version error.
All the previous 5 builds had passed for Jekyll build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya edited a comment on issue #17993:
[R][v1.6.x] Fix doc build issue on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya edited a comment on issue #17993: [R][v1.6.x] Fix doc build issue on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-611556494
@lanking520 @zachgk any idea about the Scala failure? http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-17993/4/pipeline
Since this is a network issue, generally gets resolved by retriggering the build.
Looking into the Static build 14.04 Python unix-gpu failure : it fails at apt-get update in ubuntu_publish.sh
it is on ubuntu 14.04 with nvidia-docker.
Surprisingly, master branch doesn't fail. Nor do previous commits in 1.6 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17993:
[R][v1.6.x] Fix blocked pipelines [windows, unix-cpu, unix-gpu] on v1.6.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #17993: [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x
URL: https://github.com/apache/incubator-mxnet/pull/17993#issuecomment-612115149
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services