You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/01 03:04:04 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #3478: Fix Windows shell error on JDK11

HTHou commented on a change in pull request #3478:
URL: https://github.com/apache/iotdb/pull/3478#discussion_r661937910



##########
File path: server/src/assembly/resources/conf/iotdb-env.bat
##########
@@ -77,6 +77,11 @@ if %desired_yg_in_mb% GTR %max_sensible_yg_in_mb% (
 	set HEAP_NEWSIZE=%max_sensible_yg_in_mb%M
 ) else set HEAP_NEWSIZE=%desired_yg_in_mb%M
 
+@REM Maximum heap size
+@REM MAX_HEAP_SIZE="2G"
+@REM Minimum heap size
+@REM HEAP_NEWSIZE="2G"

Review comment:
       ```suggestion
   @REM Maximum heap size
   @REM set MAX_HEAP_SIZE="2G"
   @REM Minimum heap size
   @REM set HEAP_NEWSIZE="2G"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org