You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 06:48:39 UTC

[GitHub] [airflow] BobDu commented on a diff in pull request #27917: add some important log in aws athena hook

BobDu commented on code in PR #27917:
URL: https://github.com/apache/airflow/pull/27917#discussion_r1036744105


##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -91,8 +94,12 @@ def run_query(
         }
         if client_request_token:
             params["ClientRequestToken"] = client_request_token
+        if self.log_query:
+            self.log.info("Running Query with params: %s", params)

Review Comment:
   We only log query details when option `log_query = True`, like `DbApiHook` option `log_sql`.
   So it may be better to keep using `info` level.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org