You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 05:09:05 UTC
[PR] [ISSUE #773] Surface unavailable client provider errors [rocketmq-dashboard]
Aias00 opened a new pull request, #774:
URL: https://github.com/apache/rocketmq-dashboard/pull/774
Fixes #773.
### What changed
- Surface backend client-provider errors as a visible warning on the client connections page.
- Preserve an empty statistics/table state instead of hiding the actionable error behind a generic retry toast.
- Add regression coverage for the current `Client connection provider is not configured` path.
### Validation
- `npm --prefix web test -- ClientsPage.test.tsx`
- `npm --prefix web exec -- eslint web/src/pages/cluster/clients.tsx web/src/pages/cluster/__tests__/ClientsPage.test.tsx`
- `cd web && npx tsc -b --noEmit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #773] Surface unavailable client provider errors [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #774:
URL: https://github.com/apache/rocketmq-dashboard/pull/774#issuecomment-5175478556
Superseded by consolidated PR #946, which contains this change and has passing checks. Closing this narrower PR to keep review focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #773] Surface unavailable client provider errors [rocketmq-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #774:
URL: https://github.com/apache/rocketmq-dashboard/pull/774#discussion_r3701460303
##########
web/src/pages/cluster/clients.tsx:
##########
@@ -75,6 +76,27 @@ const countBy = (values: string[]) =>
.map(([label, count]) => ({ label, count }))
.sort((a, b) => b.count - a.count || a.label.localeCompare(b.label));
+type ApiErrorLike = {
+ message?: unknown;
+ response?: {
+ data?: {
+ message?: unknown;
+ };
+ };
+};
+
+function getLoadErrorMessage(error: unknown): string {
+ const apiError = error as ApiErrorLike;
+ const responseMessage = apiError.response?.data?.message;
+ if (typeof responseMessage === 'string' && responseMessage.trim()) {
+ return responseMessage;
+ }
+ if (typeof apiError.message === 'string' && apiError.message.trim()) {
+ return apiError.message;
+ }
+ return DEFAULT_LOAD_ERROR;
+}
Review Comment:
`getLoadErrorMessage` assumes the caught value is an object and immediately reads `apiError.response...`. If the promise is rejected with `null`/`undefined` (or any non-object), this will throw inside the `catch`, preventing the page from rendering the intended empty state + warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #773] Surface unavailable client provider errors [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #774: [ISSUE #773] Surface unavailable client provider errors
URL: https://github.com/apache/rocketmq-dashboard/pull/774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org