You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/09/22 09:49:27 UTC
[GitHub] zeppelin pull request #1449: [MINOR][DOC] Change Markdown class name from Ma...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1449
[MINOR][DOC] Change Markdown class name from Markdown to MarkdownInterpreter
### What is this PR for?
Markdown interpreter's class name have changed from `Markdown` to `MarkdownInterpreter` in #1384 so this PR change markdown class name accordingly.
### What type of PR is it?
Documentation
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin update/markdownClassName
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1449
----
commit d0917308246a94a621694dc43ebbc6f1360ca37d
Author: Mina Lee <mi...@apache.org>
Date: 2016-09-22T08:31:24Z
Change Markdown class name from Markdown -> MarkdownInterpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from MarkdownInterp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1449
@kavinkumarks I think you can stop Zeppelin and replace all "org.apache.zeppelin.markdown.MarkdownInterpreter" to "org.apache.zeppelin.markdown.Markdown" in conf/interpreter.json, and then start Zeppelin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from MarkdownInterp...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1449
I am facing issues in my local on running paragraph with md interpreter since the markdown class name is 'MarkdownInterpreter' in conf/interpreter.json What should I do to resolve this without deleting the interpreter.json file?
Thanks,
Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from MarkdownInterp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1449
@kavinkumarks Yep. class name shouldn't be changed. 'MarkdownInterpreter' to 'Markdown' name change didn't happened across different versions of release. Otherwise, yes, will be taken care automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from MarkdownInterp...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1449
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from MarkdownInterp...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1449
Thanks @Leemoonsoo !
- Kavin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR][DOC] Change Markdown class name from Markdown ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1449
LGTM \U0001f44d \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR][DOC] Change Markdown class name from Markdown ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1449
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from MarkdownInterp...
Posted by kavinkumarks <gi...@git.apache.org>.
Github user kavinkumarks commented on the issue:
https://github.com/apache/zeppelin/pull/1449
@Leemoonsoo Yeah, it worked by changing it manually.I thought that it should have been taken care auto* when someone changes the relevant class name in the appropriate interpreter-setting.json What do you say?
Thanks,
Kavin
MailTo: kavin.kumar@imaginea.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR][DOC] Change Markdown class name from Markdown ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1449
In case users who already have conf/interpreter.json upgrades Zeppelin, the file includes old classname. for example
```
"interpreterSettings": {
"2BUVF72FJ": {
"id": "2BUVF72FJ",
"name": "md",
"group": "md",
"interpreterGroup": [
{
"name": "md",
"class": "org.apache.zeppelin.markdown.Markdown",
"defaultInterpreter": false
}
],
```
Will there be any problem because of classname change in this case?
Should we change `MarkdownInterpreter` to `Markdown`? or `Markdown` to `MarkdownInterpreter`?
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1449: [MINOR] Change Markdown class name from Markdown to Ma...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1449
@Leemoonsoo Thank you for pointing it out. I think changing the class name to `Markdown` is more proper way to avoid compatibility issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1449: [MINOR] Change Markdown class name from Markdow...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---