You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/05/28 18:16:55 UTC

[GitHub] [trafficcontrol] mitchell852 commented on issue #3595: Removing restangular

mitchell852 commented on issue #3595: Removing restangular
URL: https://github.com/apache/trafficcontrol/pull/3595#issuecomment-496630244
 
 
   the more I think about it, I think this PR is just way too big / risky. it requires a lot of positive and negative testing to ensure it does not change/break functionality. imo you should tackle one "service" at a time. i.e. remove the use of restangular from cdnservice.js. and move down the list of "services" with a seperate PR until nothing uses restangular and the dependency can be removed altogether. otherwise, the risk is much too high given that TP doesn't have comprehensive regression tests in place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services