You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/12/20 21:58:35 UTC
Review Request 54915: GEODE-2215: GatewaySenderAdvisor checks the
current processor to see if it has started
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54915/
-----------------------------------------------------------
Review request for geode and xiaojian zhou.
Repository: geode
Description
-------
Previously it was checking the top level sender (possibly a concurrent sendor)
This allowed a race condition where the top level sender was still starting up
but the individual processors were ready to process. They would check the flag
and because the sender was not ready, the processors would act and start initiating
failover, which left the processor in a very weird state
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ace780e
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java 9755adb
Diff: https://reviews.apache.org/r/54915/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 54915: GEODE-2215: GatewaySenderAdvisor checks the
current processor to see if it has started
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54915/#review159786
-----------------------------------------------------------
Ship it!
Ship It!
- xiaojian zhou
On Dec. 20, 2016, 9:58 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54915/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 9:58 p.m.)
>
>
> Review request for geode and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Previously it was checking the top level sender (possibly a concurrent sendor)
> This allowed a race condition where the top level sender was still starting up
> but the individual processors were ready to process. They would check the flag
> and because the sender was not ready, the processors would act and start initiating
> failover, which left the processor in a very weird state
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ace780e
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderEventProcessor.java 9755adb
>
> Diff: https://reviews.apache.org/r/54915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>