You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/31 16:33:42 UTC

[GitHub] [flink] slinkydeveloper opened a new pull request #18574: [hotfix][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

slinkydeveloper opened a new pull request #18574:
URL: https://github.com/apache/flink/pull/18574


   ## What is the purpose of the change
   
   Cleanup of previous custom ser/de for duration, and introduced jdk8 module for ser/de
   
   ## Brief change log
   
   * Use jdk 8 and java time modules for duration and optional ser/de
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18574: [hotfix][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1025977048

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 0efd57776d90956d6ec2a1d773d3d1ce34b2f75e (Mon Jan 31 16:38:52 UTC 2022)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] slinkydeveloper commented on pull request #18574: [FLINK-25942][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

slinkydeveloper commented on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1028826620


   I opened an issue here https://issues.apache.org/jira/browse/FLINK-25942. The only reason why we have on master that Duration custom ser/de is that until https://issues.apache.org/jira/browse/FLINK-25588 we hadn't the jackson module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fapaul commented on pull request #18574: [FLINK-25942][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

fapaul commented on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1028933687


   @slinkydeveloper thanks for the clarification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fapaul merged pull request #18574: [FLINK-25942][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

fapaul merged pull request #18574:
URL: https://github.com/apache/flink/pull/18574


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fapaul commented on pull request #18574: [hotfix][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

fapaul commented on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1028808294


   I would actually propose to create a ticket for this change. To me as someone with less table knowledge, it is not clear why it is safe to remove the previous serde and why it was developed in the first place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18574: [hotfix][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1025978978


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0efd57776d90956d6ec2a1d773d3d1ce34b2f75e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30535",
       "triggerID" : "0efd57776d90956d6ec2a1d773d3d1ce34b2f75e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0efd57776d90956d6ec2a1d773d3d1ce34b2f75e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30535) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18574: [hotfix][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1025978978


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0efd57776d90956d6ec2a1d773d3d1ce34b2f75e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30535",
       "triggerID" : "0efd57776d90956d6ec2a1d773d3d1ce34b2f75e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0efd57776d90956d6ec2a1d773d3d1ce34b2f75e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30535) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] slinkydeveloper edited a comment on pull request #18574: [FLINK-25942][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

slinkydeveloper edited a comment on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1028826620


   I opened an issue here https://issues.apache.org/jira/browse/FLINK-25942. The only reason why we have on master that Duration custom ser/de is that until https://issues.apache.org/jira/browse/FLINK-25588 we hadn't the jackson module that solves the problem for us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18574: [hotfix][table-planner] Use jdk 8 and java time modules for duration and optional ser/de

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #18574:
URL: https://github.com/apache/flink/pull/18574#issuecomment-1025978978


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0efd57776d90956d6ec2a1d773d3d1ce34b2f75e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0efd57776d90956d6ec2a1d773d3d1ce34b2f75e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0efd57776d90956d6ec2a1d773d3d1ce34b2f75e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org