You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/06 15:57:07 UTC
[GitHub] [submarine] noidname01 opened a new pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
noidname01 opened a new pull request #701:
URL: https://github.com/apache/submarine/pull/701
### What is this PR for?
This is the frontend implementation of [SUBMARINE-943](https://issues.apache.org/jira/browse/SUBMARINE-943)
Users can add multiple tags to mark experiments with their own category.
It's a little bit different from creating customized experiment, [SUBMARINE-958](https://issues.apache.org/jira/browse/SUBMARINE-958)
The tags are defined in template, so you can't edit it when creating the experiment.
But users can edit tags after creating the experiment.
### What type of PR is it?
[Feature]
### Todos
None
### What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-961
### How should this be tested?
Create a template with tags, and create an experiment with that template.
### Screenshots (if appropriate)
Create template with tags
Completed template
Create experiment with template
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #701:
URL: https://github.com/apache/submarine/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] noidname01 commented on pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
noidname01 commented on pull request #701:
URL: https://github.com/apache/submarine/pull/701#issuecomment-894357057
This PR should be merged after merging SUBMARINE-958. Because there are same necessary changes between them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #701:
URL: https://github.com/apache/submarine/pull/701#discussion_r690902918
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
Could we remove it?
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
+, Thanks
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
+1, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #701:
URL: https://github.com/apache/submarine/pull/701#issuecomment-900813116
yup, we should add a test for that~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #701:
URL: https://github.com/apache/submarine/pull/701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #701:
URL: https://github.com/apache/submarine/pull/701#discussion_r690902918
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
Could we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] noidname01 commented on a change in pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
noidname01 commented on a change in pull request #701:
URL: https://github.com/apache/submarine/pull/701#discussion_r690928229
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
@pingsutw Removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #701:
URL: https://github.com/apache/submarine/pull/701#discussion_r690928891
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
+, Thanks
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
+1, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] noidname01 edited a comment on pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
noidname01 edited a comment on pull request #701:
URL: https://github.com/apache/submarine/pull/701#issuecomment-894357057
This PR should be merged after merging SUBMARINE-958. Because there are same necessary changes between them. I'll fix it when SUBMARINE-958 merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #701:
URL: https://github.com/apache/submarine/pull/701#issuecomment-900813116
yup, we should add a test for that~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] noidname01 commented on pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
noidname01 commented on pull request #701:
URL: https://github.com/apache/submarine/pull/701#issuecomment-900381143
@pingsutw I fix the conflict, and I'll open new issue for creating templateIT. I think functions of template page should also be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] noidname01 commented on a change in pull request #701: SUBMARINE-961. Experiment Tag at Predefined Experiment
Posted by GitBox <gi...@apache.org>.
noidname01 commented on a change in pull request #701:
URL: https://github.com/apache/submarine/pull/701#discussion_r690928229
##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/template/template-home/template-form/template-form.component.html
##########
@@ -175,6 +175,27 @@
></textarea>
</nz-form-control>
</nz-form-item>
+ <nz-form-item>
+ <nz-form-label [nzSm]="6" [nzXs]="24" nzRequired nzFor="tags">Tags</nz-form-label>
+ <nz-form-control [nzSm]="14" [nzXs]="24" nzErrorTip="Please input tags for this template!">
+ <!-- <textarea
+ nz-input
+ [nzAutosize]="{ minRows: 1, maxRows: 4 }"
+ name="cmd"
+ formControlName="cmd"
+ id="cmd"
+ placeholder="Command for this template."
+ ></textarea> -->
Review comment:
@pingsutw Removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org