You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Gary Tully (JIRA)" <ji...@apache.org> on 2008/05/13 21:07:43 UTC

[jira] Created: (AMQ-1724) Allow ssl context configuration through spring/xbean

Allow ssl context configuration through spring/xbean
----------------------------------------------------

                 Key: AMQ-1724
                 URL: https://issues.apache.org/activemq/browse/AMQ-1724
             Project: ActiveMQ
          Issue Type: New Feature
          Components: Broker
    Affects Versions: 5.1.0
            Reporter: Gary Tully


amq ssl works with the javax.net.ssl system properties and can be configured via SslBroker without the system properties as shown in AMQ-1665. It would be better if it was possible to configure via spring or xbean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1724) Allow ssl context configuration through spring/xbean

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated AMQ-1724:
----------------------------

    Patch Info: [Patch Available]

> Allow ssl context configuration through spring/xbean
> ----------------------------------------------------
>
>                 Key: AMQ-1724
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1724
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.1.0
>            Reporter: Gary Tully
>         Attachments: AMQ-1724.patch
>
>
> amq ssl works with the javax.net.ssl system properties and can be configured via SslBroker without the system properties as shown in AMQ-1665. It would be better if it was possible to configure via spring or xbean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1724) Allow ssl context configuration through spring/xbean

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42797#action_42797 ] 

Gary Tully commented on AMQ-1724:
---------------------------------

take that back, the fact that SslTransportFactory is brokerServiceAware ensures that once a broker listens/binds to an ssl address, the brokers SslTransportFactory will be initialised and used for subsequent Ssl comms.
So long as all listening is done before client side connecting, networks etc, it will work nicely.
thanks hiram.

> Allow ssl context configuration through spring/xbean
> ----------------------------------------------------
>
>                 Key: AMQ-1724
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1724
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.1.0
>            Reporter: Gary Tully
>             Fix For: 5.2.0
>
>         Attachments: AMQ-1724.patch
>
>
> amq ssl works with the javax.net.ssl system properties and can be configured via SslBroker without the system properties as shown in AMQ-1665. It would be better if it was possible to configure via spring or xbean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1724) Allow ssl context configuration through spring/xbean

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42795#action_42795 ] 

Gary Tully commented on AMQ-1724:
---------------------------------

this config is neat, I think there is a problem though.
The SslTransportFactory needs to be made available to TransportFactory.lookup so that the runtime can find a socket factory for ssl. On the server/bind side the SslBroker has an addSslConnector to get around this, but there is no such thing on the client side.

> Allow ssl context configuration through spring/xbean
> ----------------------------------------------------
>
>                 Key: AMQ-1724
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1724
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.1.0
>            Reporter: Gary Tully
>             Fix For: 5.2.0
>
>         Attachments: AMQ-1724.patch
>
>
> amq ssl works with the javax.net.ssl system properties and can be configured via SslBroker without the system properties as shown in AMQ-1665. It would be better if it was possible to configure via spring or xbean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1724) Allow ssl context configuration through spring/xbean

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated AMQ-1724:
----------------------------

    Attachment: AMQ-1724.patch

This patch adds an SslContextInitializer interface to SslTransportFactory that is used to initialise an SSLContext. This makes it easier to inject the configuration required to support setting ssl properties from spring.
There is also an additional register method on SslTransportFactory that allows a factory to register itself as the provider of ssl sockets. This allows a spring configured factory to be used across the broker for all ssl comms, client and network.
There are a bunch of tests that show simple ssl context initialisation and more explicit initialisation using a TransportServer


> Allow ssl context configuration through spring/xbean
> ----------------------------------------------------
>
>                 Key: AMQ-1724
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1724
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.1.0
>            Reporter: Gary Tully
>         Attachments: AMQ-1724.patch
>
>
> amq ssl works with the javax.net.ssl system properties and can be configured via SslBroker without the system properties as shown in AMQ-1665. It would be better if it was possible to configure via spring or xbean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-1724) Allow ssl context configuration through spring/xbean

Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiram Chirino resolved AMQ-1724.
--------------------------------

    Fix Version/s: 5.2.0
       Resolution: Fixed

Implemented the feature with a more concise xml notation and also avoided using static singleton to hold the ssl configuration.  This allows you to configure each broker with a different ssl keystore even if there are multiple brokers in 1 JVM.

example:

{code}
  <broker>

    <sslContext>
      <sslContext 
      		keyStore="server.keystore" keyStorePassword="password"
      		trustStore="client.keystore" trustStorePassword="password"/>
    </sslContext>
    
    <transportConnectors>
      <transportConnector uri="ssl://localhost:61616" />
    </transportConnectors>
    
  </broker>
{code}

> Allow ssl context configuration through spring/xbean
> ----------------------------------------------------
>
>                 Key: AMQ-1724
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1724
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Broker
>    Affects Versions: 5.1.0
>            Reporter: Gary Tully
>             Fix For: 5.2.0
>
>         Attachments: AMQ-1724.patch
>
>
> amq ssl works with the javax.net.ssl system properties and can be configured via SslBroker without the system properties as shown in AMQ-1665. It would be better if it was possible to configure via spring or xbean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.