[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3830: [KYUUBI #3242] First stop server and then interrupt thread when stopping the frontend service

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3830:
URL: https://github.com/apache/incubator-kyuubi/pull/3830#discussion_r1033460487


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -671,6 +671,13 @@ object KyuubiConf {
       .booleanConf
       .createWithDefault(true)
 
+  val FRONTEND_THRIFT_STOP_TIMEOUT: ConfigEntry[Long] =
+    buildConf("kyuubi.frontend.thrift.stop.timeout")
+      .doc("Timeout for stop the thrift frontend service.")
+      .version("1.7.0")
+      .timeConf
+      .createWithDefault(Duration.ofSeconds(60).toMillis)

Review Comment:
   Does it mean we can not gracefully shutdown queries that requires more than this time to complete?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org