You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "jinkachy (via GitHub)" <gi...@apache.org> on 2025/03/19 07:21:56 UTC
[PR] [minor][docs][style] Update documentation link and improve code style [flink-cdc]
jinkachy opened a new pull request, #3961:
URL: https://github.com/apache/flink-cdc/pull/3961
Update documentation link and improve code style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][docs][style] Update documentation link and improve code style [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3961:
URL: https://github.com/apache/flink-cdc/pull/3961#issuecomment-3153752205
Hi, @jinkachy would you like to rebase master to solve the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][docs][style] Update documentation link and improve code style [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #3961:
URL: https://github.com/apache/flink-cdc/pull/3961#discussion_r2002649068
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksDataSinkOptions.java:
##########
Review Comment:
Please run `mvn spotless:apply` to fix any codestyle violations, and `mvn verify -DskipTests` to make sure the checker is satisfied. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][docs][style] Update documentation link and improve code style [flink-cdc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3961:
URL: https://github.com/apache/flink-cdc/pull/3961#issuecomment-3085956925
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 60 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][docs][style] Update documentation link and improve code style [flink-cdc]
Posted by "jinkachy (via GitHub)" <gi...@apache.org>.
jinkachy commented on code in PR #3961:
URL: https://github.com/apache/flink-cdc/pull/3961#discussion_r2002733514
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksDataSinkOptions.java:
##########
Review Comment:
@yuxiqian Thank you for your guidance! I've executed the suggested commands:
1. Ran `mvn spotless:apply` to fix the code style violations
2. Verified the changes locally with `mvn verify -DskipTests`, which completed successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [minor][docs][style] Update documentation link and improve code style [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan merged PR #3961:
URL: https://github.com/apache/flink-cdc/pull/3961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org