You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by Rui Wang <am...@apache.org> on 2020/08/09 03:47:11 UTC
[DISCUSS] Enable AvoidStarImport in Checkstyle
Hi community,
Have you ever discussed why "AvoidStarImport" is not enabled? I noticed
that there are some "import *" existing in the codebase and
"AvoidStarImport" is not enabled in the checkstyle config. So I opened [1]
to both enable it in config and fix "import *".
[1]: https://github.com/apache/incubator-ratis/pull/173
-Rui
Re: [DISCUSS] Enable AvoidStarImport in Checkstyle
Posted by Rui Wang <am...@apache.org>.
Indeed I am checking "address in use" frequently. Have you ever reproduced
it on your local machine (I failed to do so)
-Rui
On Sun, Aug 9, 2020 at 4:57 PM runzhiwang <wa...@qq.com> wrote:
> Hi,
>
>
> If you are interested in flaky UT. You can pay attenation to RATIS-916 and
> RATIS-1017, they all caused by java.net.BindException: Address already in
> use.
> This is the top one reason cause ut flaky.
>
>
> Thanks,
> runzhiwang
>
>
> ------------------ 原始邮件 ------------------
> 发件人:
> "dev"
> <
> amaliujia@apache.org>;
> 发送时间: 2020年8月10日(星期一) 凌晨2:12
> 收件人: "dev"<dev@ratis.apache.org>;
>
> 主题: Re: [DISCUSS] Enable AvoidStarImport in Checkstyle
>
>
>
> that sounds good :)
>
> I guess right now UT flakiness is the area that needs attention. Trying to
> be useful in that area.
>
>
> -Rui
>
> On Sun, Aug 9, 2020 at 4:09 AM Tsz Wo Sze <szetszwo@gmail.com> wrote:
>
> > +1. Thanks for working on this.
> >
> > In general, let's put our energy on the code but do not spend much
> time on
> > the imports/whitespaces. :)
> >
> > Tsz-Wo
> >
> > On Sat, Aug 8, 2020 at 8:58 PM runzhiwang <wangjie_challenge@qq.com
> >
> > wrote:
> >
> > > +1&nbsp;
> > >
> > >
> > > ------------------&nbsp;原始邮件&nbsp;------------------
> > > 发件人:
> >
> >
> "dev"
> >
> >
> <
> > > amaliujia@apache.org&gt;;
> > > 发送时间:&nbsp;2020年8月9日(星期天) 中午11:47
> > > 收件人:&nbsp;"dev"<dev@ratis.apache.org&gt;;
> > >
> > > 主题:&nbsp;[DISCUSS] Enable AvoidStarImport in Checkstyle
> > >
> > >
> > >
> > > Hi community,
> > >
> > > Have you ever discussed why "AvoidStarImport" is not enabled? I
> noticed
> > > that there are some "import *" existing in the codebase and
> > > "AvoidStarImport" is not enabled in the checkstyle config. So I
> opened
> > [1]
> > > to both enable it in config and fix "import *".
> > >
> > >
> > >
> > > [1]: https://github.com/apache/incubator-ratis/pull/173
> > <https://github.com/apache/incubator-ratis/pull/173>>; >
> > > -Rui
> >
回复： [DISCUSS] Enable AvoidStarImport in Checkstyle
Posted by runzhiwang <wa...@qq.com>.
Hi,
If you are interested in flaky UT. You can pay attenation to RATIS-916 and RATIS-1017, they all caused by java.net.BindException: Address already in use.
This is the top one reason cause ut flaky.
Thanks,
runzhiwang
------------------ 原始邮件 ------------------
发件人: "dev" <amaliujia@apache.org>;
发送时间: 2020年8月10日(星期一) 凌晨2:12
收件人: "dev"<dev@ratis.apache.org>;
主题: Re: [DISCUSS] Enable AvoidStarImport in Checkstyle
that sounds good :)
I guess right now UT flakiness is the area that needs attention. Trying to
be useful in that area.
-Rui
On Sun, Aug 9, 2020 at 4:09 AM Tsz Wo Sze <szetszwo@gmail.com> wrote:
> +1. Thanks for working on this.
>
> In general, let's put our energy on the code but do not spend much time on
> the imports/whitespaces. :)
>
> Tsz-Wo
>
> On Sat, Aug 8, 2020 at 8:58 PM runzhiwang <wangjie_challenge@qq.com>
> wrote:
>
> > +1&nbsp;
> >
> >
> > ------------------&nbsp;原始邮件&nbsp;------------------
> > 发件人:
> > "dev"
> > <
> > amaliujia@apache.org&gt;;
> > 发送时间:&nbsp;2020年8月9日(星期天) 中午11:47
> > 收件人:&nbsp;"dev"<dev@ratis.apache.org&gt;;
> >
> > 主题:&nbsp;[DISCUSS] Enable AvoidStarImport in Checkstyle
> >
> >
> >
> > Hi community,
> >
> > Have you ever discussed why "AvoidStarImport" is not enabled? I noticed
> > that there are some "import *" existing in the codebase and
> > "AvoidStarImport" is not enabled in the checkstyle config. So I opened
> [1]
> > to both enable it in config and fix "import *".
> >
> >
> >
> > [1]: https://github.com/apache/incubator-ratis/pull/173
> >
> > -Rui
>
Re: [DISCUSS] Enable AvoidStarImport in Checkstyle
Posted by Rui Wang <am...@apache.org>.
that sounds good :)
I guess right now UT flakiness is the area that needs attention. Trying to
be useful in that area.
-Rui
On Sun, Aug 9, 2020 at 4:09 AM Tsz Wo Sze <sz...@gmail.com> wrote:
> +1. Thanks for working on this.
>
> In general, let's put our energy on the code but do not spend much time on
> the imports/whitespaces. :)
>
> Tsz-Wo
>
> On Sat, Aug 8, 2020 at 8:58 PM runzhiwang <wa...@qq.com>
> wrote:
>
> > +1
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人:
> > "dev"
> > <
> > amaliujia@apache.org>;
> > 发送时间: 2020年8月9日(星期天) 中午11:47
> > 收件人: "dev"<dev@ratis.apache.org>;
> >
> > 主题: [DISCUSS] Enable AvoidStarImport in Checkstyle
> >
> >
> >
> > Hi community,
> >
> > Have you ever discussed why "AvoidStarImport" is not enabled? I noticed
> > that there are some "import *" existing in the codebase and
> > "AvoidStarImport" is not enabled in the checkstyle config. So I opened
> [1]
> > to both enable it in config and fix "import *".
> >
> >
> >
> > [1]: https://github.com/apache/incubator-ratis/pull/173
> >
> > -Rui
>
Re: [DISCUSS] Enable AvoidStarImport in Checkstyle
Posted by Tsz Wo Sze <sz...@gmail.com>.
+1. Thanks for working on this.
In general, let's put our energy on the code but do not spend much time on
the imports/whitespaces. :)
Tsz-Wo
On Sat, Aug 8, 2020 at 8:58 PM runzhiwang <wa...@qq.com> wrote:
> +1
>
>
> ------------------ 原始邮件 ------------------
> 发件人:
> "dev"
> <
> amaliujia@apache.org>;
> 发送时间: 2020年8月9日(星期天) 中午11:47
> 收件人: "dev"<dev@ratis.apache.org>;
>
> 主题: [DISCUSS] Enable AvoidStarImport in Checkstyle
>
>
>
> Hi community,
>
> Have you ever discussed why "AvoidStarImport" is not enabled? I noticed
> that there are some "import *" existing in the codebase and
> "AvoidStarImport" is not enabled in the checkstyle config. So I opened [1]
> to both enable it in config and fix "import *".
>
>
>
> [1]: https://github.com/apache/incubator-ratis/pull/173
>
> -Rui
回复：[DISCUSS] Enable AvoidStarImport in Checkstyle
Posted by runzhiwang <wa...@qq.com>.
+1
------------------ 原始邮件 ------------------
发件人: "dev" <amaliujia@apache.org>;
发送时间: 2020年8月9日(星期天) 中午11:47
收件人: "dev"<dev@ratis.apache.org>;
主题: [DISCUSS] Enable AvoidStarImport in Checkstyle
Hi community,
Have you ever discussed why "AvoidStarImport" is not enabled? I noticed
that there are some "import *" existing in the codebase and
"AvoidStarImport" is not enabled in the checkstyle config. So I opened [1]
to both enable it in config and fix "import *".
[1]: https://github.com/apache/incubator-ratis/pull/173
-Rui