[GitHub] [hbase] sershe-ms commented on a change in pull request #237: HBASE-22408 add dead and unknown server open regions metric to AM 01

[GitBox <gi...@apache.org>]

sershe-ms commented on a change in pull request #237: HBASE-22408 add dead and unknown server open regions metric to AM 01
URL: https://github.com/apache/hbase/pull/237#discussion_r284481870
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
 ##########
 @@ -620,8 +620,9 @@ public synchronized boolean expireServer(final ServerName serverName) {
     }
   }
 
+  /** This is already called from a synchronized method, so synch is for visibility sake. */
   @VisibleForTesting
-  public void moveFromOnlineToDeadServers(final ServerName sn) {
+  public synchronized void moveFromOnlineToDeadServers(final ServerName sn) {
 
 Review comment:
   I'll rename the method instead to make it obvious it requires sync, in case someone calls it from other parts of this class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services