You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/10/28 07:58:59 UTC

[GitHub] [hadoop] tasanuma commented on pull request #2418: HDFS-15657. RBF: TestRouter#testNamenodeHeartBeatEnableDefault fails by BindException

tasanuma commented on pull request #2418:
URL: https://github.com/apache/hadoop/pull/2418#issuecomment-717765124


   @aajisaka Thanks for updating PR.
   
   > According to the javadoc, this test case is to verify the default behavior. Don't set the default value (true) explicitly to verify the default behavior.
   
   I checked  [HDFS-14653](https://issues.apache.org/jira/browse/HDFS-14653) again.  `testNamenodeHeartBeatEnableDefault` checks that `DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE` is suppose to take the value of `DFS_ROUTER_HEARTBEAT_ENABLE` when `DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE` isn't explicitly specified. Therefore, the previous code here may not be wrong.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org