You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/05 09:12:09 UTC
[GitHub] [flink] zhijiangW opened a new pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
zhijiangW opened a new pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019
## What is the purpose of the change
When the `StreamTwoInputSelectableProcessor` was introduced before, it was missing to add the barrier alignment metric in the constructor. But it does not cause problems then, because only `StreamTwoInputProcessor` works at that time. After `StreamTwoInputProcessor` is replaced by `StreamTwoInputSelectableProcessor` as now, this bug is exposed and we will not see the barrier alignment metric for the case of two inputs.
The solution is to add this metric while constructing the `CheckpointBarrierHandler`.
## Brief change log
- *Add the metric of barrier alignment while constructing the `CheckpointBarrierHandler`*
## Verifying this change
Via the job testing.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375139240
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
Review comment:
nit: pass through constructor? Getting metric group from a variable named `toNotifyOnCheckpoint` looks a bit strange?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582319661
<!--
Meta data
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
-->
## CI report:
* 012203b66328bc46e9af4d37c585521915f450ca UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582319661
<!--
Meta data
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147512894 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:ac23472fe66b4c534a30aa0bde8e8ecf05021166 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ac23472fe66b4c534a30aa0bde8e8ecf05021166
-->
## CI report:
* 012203b66328bc46e9af4d37c585521915f450ca Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147512894) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851)
* ac23472fe66b4c534a30aa0bde8e8ecf05021166 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375168479
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375140363
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
+ taskIOMetricGroup.gauge("checkpointAlignmentTime", barrierHandler::getAlignmentDurationNanos);
Review comment:
deduplicate this code with `OneInputStreamTask`?
In master version I think this is also missing
```
taskIOMetricGroup.gauge("checkpointStartDelayNanos", inputGate::getCheckpointStartDelayNanos);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582319661
<!--
Meta data
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147512894 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:ac23472fe66b4c534a30aa0bde8e8ecf05021166 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147523074 TriggerType:PUSH TriggerID:ac23472fe66b4c534a30aa0bde8e8ecf05021166
Hash:ac23472fe66b4c534a30aa0bde8e8ecf05021166 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4856 TriggerType:PUSH TriggerID:ac23472fe66b4c534a30aa0bde8e8ecf05021166
-->
## CI report:
* 012203b66328bc46e9af4d37c585521915f450ca Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147512894) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851)
* ac23472fe66b4c534a30aa0bde8e8ecf05021166 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147523074) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375154315
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
+ taskIOMetricGroup.gauge("checkpointAlignmentTime", barrierHandler::getAlignmentDurationNanos);
Review comment:
>deduplicate this code with OneInputStreamTask
I considered that and actually we can remove the method of `getAlignmentDurationNanos` from `CheckpointedInputGate` to unify the way all in the constructor of `CheckpointBarrierHandler`. The current way of touching minimum change is also for catching up with the release ASAP. I would try that if not very hurry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375169950
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
+ taskIOMetricGroup.gauge("checkpointAlignmentTime", barrierHandler::getAlignmentDurationNanos);
Review comment:
After checking the code path, the unification in `OneInputStreamTask` is not strong related to this fix. So I prefer to submitting a hotfix or separate ticket for handling the case of `OneInputStreamTask` in master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582312163
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 012203b66328bc46e9af4d37c585521915f450ca (Wed Feb 05 09:14:40 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582338282
Thanks for the review @pnowojski . I already submitted the updates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582319661
<!--
Meta data
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147512894 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
-->
## CI report:
* 012203b66328bc46e9af4d37c585521915f450ca Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147512894) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582418433
The failing python build should be unrelated. See [FLINK-15921](https://issues.apache.org/jira/browse/FLINK-15921). +1 for merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582333623
@zhijiangW if you think it's better to have this minimal change for release-1.10 and do the more proper fixes for master +1 from my side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375154315
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
+ taskIOMetricGroup.gauge("checkpointAlignmentTime", barrierHandler::getAlignmentDurationNanos);
Review comment:
>deduplicate this code with OneInputStreamTask
I considered that and actually we can remove the method of `getAlignmentDurationNanos` from `CheckpointedInputGate` to unify the way all in the constructor of `CheckpointBarrierHandler`. The current way of touching minimum change is also for catching up with the release ASAP. I would try that if not very hurry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375152356
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
Review comment:
I agree with the point, and the current way is for avoiding the more changes of existing tests. Let me try that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#discussion_r375154631
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -90,6 +91,10 @@ public static CheckpointedInputGate createCheckpointedInputGate(
inputGate1.getNumberOfInputChannels() + inputGate2.getNumberOfInputChannels(),
taskName,
toNotifyOnCheckpoint);
+
+ TaskIOMetricGroup taskIOMetricGroup = toNotifyOnCheckpoint.getEnvironment().getMetricGroup().getIOMetricGroup();
+ taskIOMetricGroup.gauge("checkpointAlignmentTime", barrierHandler::getAlignmentDurationNanos);
Review comment:
Let me check the issue of `checkpointStartDelayNanos`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11019:
[FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for
the case of two inputs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11019: [FLINK-15914][checkpointing][metrics] Miss the barrier alignment metric for the case of two inputs
URL: https://github.com/apache/flink/pull/11019#issuecomment-582319661
<!--
Meta data
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147512894 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:012203b66328bc46e9af4d37c585521915f450ca Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851 TriggerType:PUSH TriggerID:012203b66328bc46e9af4d37c585521915f450ca
Hash:ac23472fe66b4c534a30aa0bde8e8ecf05021166 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147523074 TriggerType:PUSH TriggerID:ac23472fe66b4c534a30aa0bde8e8ecf05021166
Hash:ac23472fe66b4c534a30aa0bde8e8ecf05021166 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4856 TriggerType:PUSH TriggerID:ac23472fe66b4c534a30aa0bde8e8ecf05021166
-->
## CI report:
* 012203b66328bc46e9af4d37c585521915f450ca Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147512894) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4851)
* ac23472fe66b4c534a30aa0bde8e8ecf05021166 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147523074) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services