You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/22 11:19:37 UTC
[GitHub] [hadoop] steveloughran commented on a change in pull request #2216: HADOOP-17194. Adding Context class for AbfsClient in ABFS
steveloughran commented on a change in pull request #2216:
URL: https://github.com/apache/hadoop/pull/2216#discussion_r475079711
##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientContext.java
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+/**
+ * Class to hold extra configurations for AbfsClient and further classes
+ * inside AbfsClient.
+ */
+public class AbfsClientContext {
Review comment:
Mixiing the builder with the implementation is a bit, well, cheating, isn't it? More importantly -it stops the context being immutable. Could you split into a builder and acutal context?
##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientContext.java
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+/**
+ * Class to hold extra configurations for AbfsClient and further classes
+ * inside AbfsClient.
+ */
+public class AbfsClientContext {
+
+ private ExponentialRetryPolicy exponentialRetryPolicy;
+ private AbfsPerfTracker abfsPerfTracker;
+ private AbfsCounters abfsCounters;
+
+ public AbfsClientContext withExponentialRetryPolicy(
+ final ExponentialRetryPolicy exponentialRetryPolicy) {
+ this.exponentialRetryPolicy = exponentialRetryPolicy;
+ return this;
+ }
+
+ public AbfsClientContext withAbfsPerfTracker(
+ final AbfsPerfTracker abfsPerfTracker) {
+ this.abfsPerfTracker = abfsPerfTracker;
+ return this;
+ }
+
+ public AbfsClientContext withAbfsCounters(final AbfsCounters abfsCounters) {
+ this.abfsCounters = abfsCounters;
+ return this;
+ }
+
+ /**
+ * Build the context and get the instance with the properties selected.
+ *
+ * @return an instance of AbfsClientContext.
+ */
+ public AbfsClientContext build() {
+ return this;
Review comment:
this (once moved to the separate builder) could be a place to validate things for not being null
##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientContext.java
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+/**
+ * Class to hold extra configurations for AbfsClient and further classes
+ * inside AbfsClient.
+ */
+public class AbfsClientContext {
+
+ private ExponentialRetryPolicy exponentialRetryPolicy;
Review comment:
I was going to suggest making this a generai RetryPolicy rather than the explicit exponential one -but I see this isn't the normal hadoop-common retry policy, just one unique to abfs. So moot. If we find that retry policy is too inflexible, then it would be time to revisit that decision.
##########
File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -1214,7 +1217,7 @@ public boolean isAtomicRenameKey(String key) {
}
private void initializeClient(URI uri, String fileSystemName,
- String accountName, boolean isSecure, AbfsCounters abfsCounters)
+ String accountName, boolean isSecure)
Review comment:
let's add some javadocs. In particularly highlighting this is is a one-off operation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org